Draft
Conversation
…prep for refactoring into radix-2^2
…required amount of passes over memory
…at performance is like
…o see what performance is like" This reverts commit 29a8a1e.
…through the parallelized radix-2^2 kernel
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 99.79% 94.15% -5.65%
==========================================
Files 8 8
Lines 1438 1812 +374
==========================================
+ Hits 1435 1706 +271
- Misses 3 106 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #103
Adds parallelism to the FFT kernel scaffold, which lets us parallelize the final few stages that aren't parallelized by recursion.
Recursion is still preferable because it provides natural cache locality and makes the algorithm cache-oblivious.
Performance vs main: -27% time taken on Zen4, -38% time taken on M4
measured on
cargo run --profile=profiling --all-features --example benchmark -- 64 28 5