feat: Add additional RoborockDockErrorCode values#811
Open
allenporter wants to merge 2 commits intoPython-roborock:mainfrom
Open
feat: Add additional RoborockDockErrorCode values#811allenporter wants to merge 2 commits intoPython-roborock:mainfrom
allenporter wants to merge 2 commits intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the V1 dock error-code mappings to cover additional Auto-Empty dock error conditions, aiming to provide richer descriptions for future user-facing messaging.
Changes:
- Added new
RoborockDockErrorCodeenum values for additional dock error codes (e.g., 32, 33, 35). - Added descriptive text intended to document each dock error code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional error codes that are missing from the auto-empty dock error codes. This also adds some additional pydoc for each enum value since sometimes the enum name values do not really describe the problem in much detail, which we can capture now to use later when showing user error messages.
Issue: home-assistant/core#163872