Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roborock/data/b01_q7/b01_q7_containers.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ class B01Props(RoborockBase):
water: WaterLevelMapping | None = None
mode: CleanTypeMapping | None = None
quantity: int | None = None
battery: int | None = None
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to clarify, I instead mean add a @Property called battery that returns quantity. As this stands now, battery will always be None here

alarm: int | None = None
volume: int | None = None
hypa: int | None = None
Expand Down
1 change: 1 addition & 0 deletions roborock/roborock_message.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ class RoborockB01Props(StrEnum):
WATER = "water"
MODE = "mode"
QUANTITY = "quantity"
BATTERY = "quantity"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the above message, you can throw a comment next to quantity though and state that it is really battery, but I don't think we should have this extra enum member.

ALARM = "alarm"
VOLUME = "volume"
HYPA = "hypa"
Expand Down
Loading