-
Notifications
You must be signed in to change notification settings - Fork 75
feat: Q7 Get battery level #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−1
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d4805d5
feat: Q7 Get battery level
RaddedMC 2f5cc5d
feat: Q7 Get battery level
RaddedMC 480fb8b
Merge branch 'main' of https://github.com/RaddedMC/python-roborock
RaddedMC 2d7cf36
Merge branch 'main' of https://github.com/RaddedMC/python-roborock
RaddedMC dec8cc4
Merge branch 'main' of https://github.com/RaddedMC/python-roborock
RaddedMC d07916a
Run lint
RaddedMC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,6 +165,7 @@ class RoborockB01Props(StrEnum): | |
| WATER = "water" | ||
| MODE = "mode" | ||
| QUANTITY = "quantity" | ||
| BATTERY = "quantity" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See the above message, you can throw a comment next to quantity though and state that it is really battery, but I don't think we should have this extra enum member. |
||
| ALARM = "alarm" | ||
| VOLUME = "volume" | ||
| HYPA = "hypa" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to clarify, I instead mean add a @Property called battery that returns quantity. As this stands now, battery will always be None here