Skip to content

fix: revert A01 padding #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 2 commits into from
Dec 20, 2025
Merged

fix: revert A01 padding #694

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef6a03
fix: revert A01 padding
Lash-L Dec 20, 2025
479c285
chore: update snapshot
Lash-L Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions roborock/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def _encode(self, obj, context, _):
if context.version == b"A01":
iv = md5hex(format(context.random, "08x") + A01_HASH)[8:24]
decipher = AES.new(bytes(context.search("local_key"), "utf-8"), AES.MODE_CBC, bytes(iv, "utf-8"))
return decipher.encrypt(pad(obj, AES.block_size))
return decipher.encrypt(obj)
elif context.version == b"B01":
iv = md5hex(f"{context.random:08x}" + B01_HASH)[9:25]
decipher = AES.new(bytes(context.search("local_key"), "utf-8"), AES.MODE_CBC, bytes(iv, "utf-8"))
Expand All @@ -300,7 +300,7 @@ def _decode(self, obj, context, _):
if context.version == b"A01":
iv = md5hex(format(context.random, "08x") + A01_HASH)[8:24]
decipher = AES.new(bytes(context.search("local_key"), "utf-8"), AES.MODE_CBC, bytes(iv, "utf-8"))
return unpad(decipher.decrypt(obj), AES.block_size)
return decipher.decrypt(obj)
elif context.version == b"B01":
iv = md5hex(f"{context.random:08x}" + B01_HASH)[9:25]
decipher = AES.new(bytes(context.search("local_key"), "utf-8"), AES.MODE_CBC, bytes(iv, "utf-8"))
Expand Down
Loading