refactor(voice): Rewrite Voice Internals & DAVE Support (send)#2873
Open
DA-344 wants to merge 84 commits intoPycord-Development:masterfrom
Open
refactor(voice): Rewrite Voice Internals & DAVE Support (send)#2873DA-344 wants to merge 84 commits intoPycord-Development:masterfrom
DA-344 wants to merge 84 commits intoPycord-Development:masterfrom
Conversation
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
DA-344
changed the title
…344/pycord into feat/voice-rewrite-and-fixes
Member
|
if we have to do breaking changes with sinks, then do it now. |
Paillat-dev
changed the title
Lulalaby
requested changes
Mar 4, 2026
Comment on lines
+1
to
+6
| """ | ||
| discord.voice.packets | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Sink packet handlers. | ||
| """ |
| @@ -0,0 +1,8 @@ | |||
| from .reader import AudioReader | |||
Paillat-dev
requested changes
Mar 4, 2026
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| from .utils import deprecated |
Member
There was a problem hiding this comment.
Use the from typing_extensions import deprecated one
This comment was marked as resolved.
This comment was marked as resolved.
This was
unlinked from
issues
Mar 4, 2026
Closed
Paillat-dev
changed the title
Member
|
@AhmedERady Currently voice reception does not work, and will most likely not through this pull request. |
This was
linked to
issues
Mar 4, 2026
Paillat-dev
reviewed
Mar 4, 2026
Paillat-dev
reviewed
Mar 4, 2026
| break | ||
| else: | ||
| self.counter += 1 | ||
| time.sleep(self.delay) |
Member
There was a problem hiding this comment.
This will sleep for 5000 seconds
Paillat-dev
reviewed
Mar 4, 2026
Paillat-dev
reviewed
Mar 4, 2026
Revnoplex
reviewed
Mar 5, 2026
Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Contributor
Author
breaking changes to sinks will be made in the sinks PR instead |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Yes @YousofHajHasan , you can follow development here: #3139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites voice internals to have a cleaner, easier-to-maintain, voice implementation.
Adds support for DAVE connections.
Voice receive is currently broken
-> This code is partially inspired on discord.py's current voice implementation
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.Related
Fixes #2833