Skip to content

Async adafruit rfm9x#177

Merged
thetazero merged 2 commits into
mainfrom
async_adafruit_rfm9x
Aug 16, 2022
Merged

Async adafruit rfm9x#177
thetazero merged 2 commits into
mainfrom
async_adafruit_rfm9x

Conversation

@thetazero
Copy link
Copy Markdown
Member

@thetazero thetazero commented Aug 12, 2022

  • Updated to most recent version of adafruit_rfm9x
  • Modified lightly to not disrupt the event loop by deferring the flow of execution at appropriate times
  • Made the LED blink at 5HZ so disruptions to the event loop could be easily seen

Note for code review:
It probably makes sense not to look at the changes to adafruit_rfm9x here, but rather in this pull to our new RFM9x_asyncio repo.

@thetazero thetazero added the bug Something isn't working label Aug 12, 2022
@thetazero thetazero added this to the V1.0.0 (Adrastea) milestone Aug 12, 2022
@thetazero thetazero self-assigned this Aug 12, 2022
@thetazero thetazero linked an issue Aug 12, 2022 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown

@yashika-batra yashika-batra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@thetazero thetazero linked an issue Aug 15, 2022 that may be closed by this pull request
Base automatically changed from driver_for_v4 to main August 16, 2022 16:47
@thetazero thetazero merged commit 8bdc15c into main Aug 16, 2022
@thetazero thetazero deleted the async_adafruit_rfm9x branch August 16, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework adafruit_rfm9x library to support asyncio Send with ack is blocking for the rfm9x library

2 participants