Threshold queries#14
Conversation
uses new init time scheme
Attempt to resolve unit test issues
| return success | ||
|
|
||
| @staticmethod | ||
| def int_cmp(x, y): |
There was a problem hiding this comment.
I'm curious what is this intended to do?
There was a problem hiding this comment.
Don't' believe we need this anymore
thetazero
left a comment
thetazero
left a comment
There was a problem hiding this comment.
Probably want to change the get_data_at_field_threshold to something more like get_field_filtered(field, filter_fn)
|
closes #7 |
|
|
||
| return entries | ||
|
|
||
| def get_field_filtered(self, |
There was a problem hiding this comment.
Another thought, given our memory issues we probably want to require a limit on the number of entries you get back.
Otherwise calling get_field_filtered is pretty dangerous, you have no idea how much memory will be allocated in the worst case.
thetazero
left a comment
thetazero
left a comment
There was a problem hiding this comment.
Looks good, seems really easy to work with now.
I think we should consider the memory impact carefully.
| - 'a | ||
| - is the value that you want to compare the data to | ||
|
|
||
| goal: |
There was a problem hiding this comment.
probably want to clean up the docstring too, shoud be much shorter now atleast.
2 participants
query any field based on a threshold input.