Remove unused _ENCODING_PATTERN regex and re import#2525
Merged
DanielNoord merged 1 commit intoPyCQA:mainfrom Apr 30, 2026
Merged
Remove unused _ENCODING_PATTERN regex and re import#2525DanielNoord merged 1 commit intoPyCQA:mainfrom
DanielNoord merged 1 commit intoPyCQA:mainfrom
Conversation
DanielNoord
approved these changes
Apr 30, 2026
Member
DanielNoord
left a comment
There was a problem hiding this comment.
If CI is green this LGTM :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
- Coverage 99.15% 99.15% -0.01%
==========================================
Files 41 41
Lines 3092 3090 -2
Branches 668 668
==========================================
- Hits 3066 3064 -2
Misses 14 14
Partials 12 12 🚀 New features to boost your workflow:
|
Contributor
Author
|
will circle back again in a few months just to clean things up (if there's anything)! but by and large this is a really well maintained library. oh and we're users of it too. thanks for this amazing library too 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hihi! doing some cleanup!
Found some dead code here ..
_ENCODING_PATTERNinisort/io.pyis a compiled regex that is never referenced anywhere in the codebase. Removed along with the now-unusedimport re.Dead code was identified using Skylos.