Skip to content

Remove unused _ENCODING_PATTERN regex and re import#2525

Merged
DanielNoord merged 1 commit intoPyCQA:mainfrom
duriantaco:remove-dead-code
Apr 30, 2026
Merged

Remove unused _ENCODING_PATTERN regex and re import#2525
DanielNoord merged 1 commit intoPyCQA:mainfrom
duriantaco:remove-dead-code

Conversation

@duriantaco
Copy link
Copy Markdown
Contributor

Hihi! doing some cleanup!

Found some dead code here .. _ENCODING_PATTERN in isort/io.py is a compiled regex that is never referenced anywhere in the codebase. Removed along with the now-unused import re.

Dead code was identified using Skylos.

Copy link
Copy Markdown
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green this LGTM :)

@DanielNoord DanielNoord enabled auto-merge April 30, 2026 14:46
@DanielNoord DanielNoord added this pull request to the merge queue Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (048e370) to head (d97047d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files          41       41              
  Lines        3092     3090       -2     
  Branches      668      668              
==========================================
- Hits         3066     3064       -2     
  Misses         14       14              
  Partials       12       12              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into PyCQA:main with commit ab9cd36 Apr 30, 2026
26 checks passed
@duriantaco
Copy link
Copy Markdown
Contributor Author

will circle back again in a few months just to clean things up (if there's anything)! but by and large this is a really well maintained library. oh and we're users of it too. thanks for this amazing library too 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants