feat: Exclude zeros and missing values PXWEB-1016#186
Merged
Conversation
Introduced ExcludeZerosAndMissingValues property to CsvSerializer. When enabled, rows (or the single heading row) containing only zero or missing values are omitted from the CSV output by checking with df.IsZeroRow. This helps produce cleaner exports by removing irrelevant data rows.
Previously, ZeroOption was always set to NoZeroNilAndSymbol in the DataFormatter. Now, it is only set when ExcludeZerosAndMissingValues is true, allowing for more flexible handling of zero and missing values in CSV serialization.
Added caching to efficiently detect and skip empty rows when serializing PXModel tables to HTML. Introduced StubX and AreAllEmptyRows methods for row grouping and emptiness checks. Changed ExcludeZerosAndMissingValues default to true, so empty rows are excluded by default. Improves performance and output clarity.
Renamed the StubX method to CalculateStubRepeat for clarity and converted it to a static method. Updated all references to use the new method name, improving code readability and organization.
Introduced ExcludeZerosAndMissingValues property to CsvSerializer. When enabled, rows (or the single heading row) containing only zero or missing values are omitted from the CSV output by checking with df.IsZeroRow. This helps produce cleaner exports by removing irrelevant data rows.
Previously, ZeroOption was always set to NoZeroNilAndSymbol in the DataFormatter. Now, it is only set when ExcludeZerosAndMissingValues is true, allowing for more flexible handling of zero and missing values in CSV serialization.
Added caching to efficiently detect and skip empty rows when serializing PXModel tables to HTML. Introduced StubX and AreAllEmptyRows methods for row grouping and emptiness checks. Changed ExcludeZerosAndMissingValues default to true, so empty rows are excluded by default. Improves performance and output clarity.
Renamed the StubX method to CalculateStubRepeat for clarity and converted it to a static method. Updated all references to use the new method name, improving code readability and organization.
…Axis.Serializers into feature/exclude-zeros
Introduced ExcludeZerosAndMissingValues and ValueLablesDisplay properties to the serializer. When enabled, rows containing only zeros or missing values are omitted from the exported XLSX. Refactored stub heading writing to support this feature using a new recursive WriteStubHeading method. Updated data row writing logic to skip excluded rows. Removed legacy stub heading code in favor of the new approach.
…Axis.Serializers into feature/exclude-zeros
The line 'return sc;' was removed, indicating a change in the method's return behavior or type. No replacement code was added, simplifying the method's logic.
Refactored WriteTableWithnHeadingVariables and WriteTableWithSubVariables to remove value and df parameters. These methods now instantiate their own local variables, resulting in cleaner interfaces and improved encapsulation. Updated WriteTable to use the new method signatures.
|
likp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to exclude zeros and missing values called
ExcludeZerosAndMissingValuesin the following file formatsDefault value is
falsesetting it totruewill not write row that are just zero or a missing value.