refactor: change recipes to be an object where keys are their resource identifiers#37
Merged
Snowiiii merged 2 commits intoPumpkin-MC:masterfrom Apr 9, 2026
Merged
Conversation
…n array of recipes
…n array of recipes
Laptop59
changed the title
Member
|
LGTM. Thank you @Laptop59 :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we want to be able to implement recipe books later, we need to store recipes by ID in the player for the recipe book they have. Currently, the generated
advancements.jsonfile does not store the IDs of the recipe.This PR changes the generated
advancements.jsonfrom storing an array of recipes to storing an object having key-value pairs where the key is the resource identifier of the recipe to store (for example,minecraft:iron_nugget), and the value is the actual structure of the recipe, containing ingredients, output, their category, etc.