fix(api): isolate docker runtime from host socket#249
Merged
skulidropek merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
6eb57a4 to
b3d0a43
Compare
Member
Author
b3d0a43 to
4b6dddc
Compare
Member
Author
Member
Author
|
Proof for isolated Docker runtime fix (SHA
Previously failing e2e jobs now pass in CI:
Local validation before push:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/var/run/docker.sockbind from the docker-git API controller compose filesdocker-git-apifor isolated project runtime stateProof
bun run checkbun run testdocker compose -f docker-compose.yml configshows no/var/run/docker.sock:/var/run/docker.sockbind mountdocker-git-api-isolated-smokeon port3344curl /healthinside controller returned{"ok":true,"revision":"unknown","cwd":"/workspace","projectsRoot":"/home/dev/.docker-git"}docker infoinside controller returnedisolated=29.1.3 root=/var/lib/dockerdocker inspectmounts were only/home/dev/.docker-gitand/var/lib/dockerNotes
This protects the host Docker daemon from docker-git project lifecycle operations by default. The controller still needs host Docker only to start the controller container itself; project containers and docker-git-api runtime Docker commands use the managed daemon inside the controller.