feat: return error if verifySignature fail#149
Open
guilhem wants to merge 1 commit intoProtonMail:mainfrom
Open
feat: return error if verifySignature fail#149guilhem wants to merge 1 commit intoProtonMail:mainfrom
guilhem wants to merge 1 commit intoProtonMail:mainfrom
Conversation
This prevent hard plumbing and to only use io.Reader interface with security. VerifySignature() doesn't return error if verifyKeyRing isn't specified. Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
| processSignatureExpiration(msg.details, msg.verifyTime) | ||
| err = verifyDetailsSignature(msg.details, msg.verifyKeyRing) | ||
| } else { | ||
| err = errors.New("gopenpgp: no verify keyring was provided before decryption") |
Contributor
There was a problem hiding this comment.
The API is such that if the caller sets the verification key ring to nil, the library should not do any verification. So I don't think we need an error here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevent hard plumbing and to only use io.Reader interface with
security.
Signed-off-by: Guilhem Lettron guilhem@barpilot.io