[Sim, Tests] Improve sim. Add sim tests. by egorshamshura · Pull Request #16 · ProteusLab/Protea

egorshamshura · 2026-03-01T17:37:22Z

No description provided.

derzhavin3016 · 2026-03-17T11:08:29Z

.clang-format

@@ -0,0 +1,167 @@
+---


Changes to clang format should be discussed, this change is not related to this PR. Consider using either minimal default clang format (e.g. LLVM), or remove this file completely

Started to use LLVM format

derzhavin3016 · 2026-03-17T11:10:29Z

Pls separate formatting commits

derzhavin3016 · 2026-03-17T11:11:17Z

.github/workflows/build.yml

+    name: Test
    runs-on: ubuntu-22.04
+    container: 
+      image: ghcr.io/egorshamshura/protea-build:latest


What does the image contain? Add more info

derzhavin3016 · 2026-03-17T11:12:05Z

cmake/QEMU.cmake

@@ -0,0 +1,3 @@
+if (NOT DEFINED QEMU_PATH)
+  set(QEMU_PATH "qemu")


Add message

Added status message

uslsteen · 2026-03-17T11:20:07Z

sim_gen/ExecEngines/naive_interpreter.rb

        emitter.emit_line("void do#{instruction[:name].to_s.upcase}(CPU &cpu, const Instruction &insn) {")
        emitter.increase_indent
-
+        


Please, remove redundant tabulations and spaces

…unctions. Add LLVM based clang-format.

derzhavin3016 · 2026-03-17T11:19:42Z

test/SimTests/Common/RunTests.py

+
+has_error = False
+
+for filename in os.listdir(directory):


Is possible to use ctest facilities to run all tests in parallel?

Added ctest

derzhavin3016 · 2026-03-23T08:48:19Z

test/SimTests/C/CImpl/qsort/qsort.c

@@ -0,0 +1,179 @@
+// See LICENSE for license details.


This file (LICENSE) should be put near benchmark sources

derzhavin3016 · 2026-03-23T08:48:54Z

test/SimTests/Common/RunTests.py

+program = sys.argv[1]
+directory = sys.argv[2]


Pls use argparse

Removed this file

derzhavin3016 · 2026-03-23T08:49:42Z

test/SimTests/Common/RunTests.py

+            has_error = True
+            continue
+
+        match = re.search(r"Exiting with code (\d+)", result.stdout)


Seems like it would be simpler to propagate exit() code as simulator exit code

Removed this file

derzhavin3016 · 2026-03-23T08:51:00Z

test/SimTests/SnippetBased/SnippetBasedImpl/InitTestGen.rb

+          next if attrs.include?(:zero) || attrs.include?(:pc)
+          size = reg[:size] || 32
+          max = (1 << size) - 1
+          values[reg[:name]] = rand(0..max)


How this works random works? Does it have seed value? If no, tests are unpredictable, if yes, consider passing it via cmdline

derzhavin3016 · 2026-03-23T08:51:42Z

test/SimTests/SnippetBased/SnippetBasedImpl/InitTestGen.rb

+  if ARGV.size < 3 || ARGV.size > 4
+    puts "Usage: #{$0} <ir_yaml_file> <snippets_directory> <output_directory> [num_tests]"
+    exit 1
+  end


Pls use built in Ruby CLI facilities

Added OptionParser

derzhavin3016 · 2026-03-23T08:52:25Z

test/SimTests/SnippetBased/SnippetBasedImpl/InitTestGen.rb

+    num_tests.times do |i|
+      output_file = File.join(output_directory, "#{base}_#{i}.init.")
+      generator.generate(formatter, snippet_content, output_file)


Could it be run in parallel?

Yes, now it is possible to specify number of threads via cmdline option

…s in CMakePresets.

egorshamshura force-pushed the add-tests-and-improve-sim branch 3 times, most recently from 778da7a to b10499c Compare March 1, 2026 17:55

egorshamshura force-pushed the add-tests-and-improve-sim branch 5 times, most recently from 769dcfe to 5fdfd4f Compare March 12, 2026 07:41

derzhavin3016 reviewed Mar 17, 2026

View reviewed changes

uslsteen reviewed Mar 17, 2026

View reviewed changes

egorshamshura added 5 commits March 17, 2026 11:36

[SimTests] Add Simtests: snippetbased and C.

07f03b3

[CI] Add tests in workflow.

eaf895a

[ADL, CodeGen] Add interface functions. Small codegen fix.

1f5bfe0

[Sim, ClangFormat] Add target dependent file to implement interface f…

c88d17a

…unctions. Add LLVM based clang-format.

[SimGen, CMake] Remove redundant whitespaces. Add status message.

f00a942

egorshamshura force-pushed the add-tests-and-improve-sim branch from 29b2c66 to f00a942 Compare March 17, 2026 11:45

derzhavin3016 reviewed Mar 23, 2026

View reviewed changes

[Sim] Added --propagate-exit flag.

7422684

egorshamshura force-pushed the add-tests-and-improve-sim branch from 9986ac2 to d6f4b6b Compare March 23, 2026 11:22

[CTest] Start to use CTest instead of python-scripts. Add test preset…

8eed710

…s in CMakePresets.

egorshamshura force-pushed the add-tests-and-improve-sim branch from e15114d to 8eed710 Compare March 23, 2026 11:36

[CMake] Add new presets.

38bf9a3

		@@ -0,0 +1,3 @@
		if (NOT DEFINED QEMU_PATH)
		set(QEMU_PATH "qemu")

		emitter.emit_line("void do#{instruction[:name].to_s.upcase}(CPU &cpu, const Instruction &insn) {")
		emitter.increase_indent

		program = sys.argv[1]
		directory = sys.argv[2]

Conversation

egorshamshura commented Mar 1, 2026

Uh oh!

derzhavin3016 Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

egorshamshura Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

derzhavin3016 commented Mar 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

derzhavin3016 Mar 17, 2026 •

edited

Loading

egorshamshura Mar 17, 2026 •

edited

Loading