Merged
Conversation
mtk3d
changed the title
mtk3d
changed the title
mtk3d
force-pushed
the
feature/add-predis-support
branch
6 times, most recently
from
bdbd3f9 to
a3c7a3e
Compare
Contributor
Author
|
Ok, it's ready now |
|
Any updates about this? Could be really nice :) |
Member
|
This looks really good @mtk3d. I just tested it locally and yes it looks good. It would be good to add predis to the blackbox tests as well (4b72fa6#diff-01564c350b960b1aa754a407d2fd8730ce62c5330010e834739d460e123d87e8R43) and there are a few style checks that fail ATM. Can you please have a look for those? We then can release this quite soon :) |
simPod
requested changes
Mar 18, 2026
Contributor
|
@mtk3d CI on main now passes, you can rebase |
mtk3d
force-pushed
the
feature/add-predis-support
branch
from
cc364ef to
1c8994c
Compare
Contributor
Author
|
Thanks for checking and all suggestions. I've applied them and also rebased main branch |
Contributor
|
Ill check it tmrw. Make sure CI passes please. You can open secondary PR against your fork to be able to trigger actions yourself if needed. |
mtk3d
force-pushed
the
feature/add-predis-support
branch
from
27ee2d8 to
2566bbc
Compare
simPod
requested changes
Mar 20, 2026
Contributor
simPod
left a comment
simPod
left a comment
There was a problem hiding this comment.
Overall LGTM, few more stuff to check
mtk3d
commented
Mar 22, 2026
mtk3d
commented
Mar 22, 2026
mtk3d
commented
Mar 22, 2026
mtk3d
commented
Mar 22, 2026
mtk3d
commented
Mar 22, 2026
mtk3d
force-pushed
the
feature/add-predis-support
branch
2 times, most recently
from
a2db6d8 to
dbb236b
Compare
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
This code has been mentioned as issue because of recurency call. Afeter quick analyse, I've realised that this is dead code, and it's not used anywhere. Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
https://github.com/PromPHP/prometheus_client_php/pull/186/changes#r2953935115 Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
This is also required by PHPStan Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
For some reason PHPStan cannot recognize that this method is returning mixed, and still trying to use int in this code, so this function would always fall in to if statement. Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
…version Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
That allowed me to simplify this adapter as well as removing some confusing parts of code, where some settings are required but not used Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
Signed-off-by: Mateusz Cholewka <mateusz@cholewka.com.pl>
mtk3d
force-pushed
the
feature/add-predis-support
branch
from
dfae421 to
ae19f84
Compare
Contributor
Author
|
Ok, done. Thank you @simPod for detailed review! I really appreciate your work. |
LKaemmerling
approved these changes
Mar 24, 2026
simPod
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I've introduced changes to support Predis as an alternative Redis connection adapter, while maintaining full backward compatibility and avoiding code duplication.
This was achieved by introducing a minimal RedisClient interface, designed according to the YAGNI principle. It only exposes the necessary methods required by the prometheus adapter.
AbstractRedis.php is basically all redis generic logic moved from Redis.php
I know there already is a PR with predis but it seems abandoned.
I see there is still need to have support for predis, also I need one for my project. So I decided to make this one, and I’m ready to help bring it across the finish line 😄
All tests are passing locally, and the code style checks are green, so I hope there will be no issues in pipeline.