Enable dynamic properties in EntityDynamic class#60
Enable dynamic properties in EntityDynamic class#60jahidulpabelislam wants to merge 1 commit intoPrintNode:masterfrom
Conversation
Add AllowDynamicProperties attribute to EntityDynamic class.
|
Hi @jahidulpabelislam , I'm having the same issue but you need to make one more change to our PR. You have to bump the required php version in the composer.json:
I think this is necessary for someone that is using php 8.0 or 8.1 or else they would get an error. If someone uses these php versions they would still get the current version of PrintNode (2.1.0) without your code changes. @PrintNodeLtd and @matthewjwbyrne could you have a look at this? I'm getting a lot of the deprecated warning in php 8.4. Thank you More details about this issue here |
|
@itx-ag I believe using the attribute on a older versions of PHP like this is fine from my testing. I've not seen it error. |
|
Hi @jahidulpabelislam it will not error in php 7 version but double check with version 8.0 and 8.1. Just a note, like I said I'm not 100% sure this is happening. If you say it works in those php versions I believe you. |
Add AllowDynamicProperties attribute to EntityDynamic class.