Use sampling chat template kwargs for renderer RL#2605
Draft
eligotts wants to merge 1 commit into
Draft
Conversation
This was referenced May 23, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orchestrator.train.sampling.extra_body.chat_template_kwargsas the hosted RL config path for renderer template controls.We are intentionally extracting this info from sampling
chat_template_kwargsinstead of adding a renderer config field. Longer term, this should move toward typed pydantic config models with explicit renderer-specific template args, so users cannot dump arbitrary keys into config. Until then, renderers validate accepted kwargs and alert on unsupported keys.Companion PRs
Validation
uvx ruff check packages/prime-rl-configs/src/prime_rl/configs/orchestrator.py skills/configs/SKILL.md src/prime_rl/orchestrator/orchestrator.py src/prime_rl/trainer/sft/data.py src/prime_rl/utils/client.py tests/unit/orchestrator/test_orchestrator_setup.py tests/unit/test_configs.pyPYTHONPATH=src:packages/prime-rl-configs/src:deps/pydantic-config/src:deps/verifiers:deps/renderers uv run --no-sync --with psutil --with setproctitle --with openai-harmony --with tiktoken --with fastokens --with prime --with "wandb>=0.26.1" python -m pytest tests/unit/test_configs.py -k "chat_template_kwargs"Note:
tests/unit/orchestrator/test_orchestrator_setup.py -k setup_student_inference_pool_uses_renderer_when_enabledcannot collect in this local Mac env becausetorchtitanis missing at import time.