Skip to content
This repository was archived by the owner on Dec 1, 2020. It is now read-only.

Updation in producttooltip.php#6

Open
deepankar321 wants to merge 4 commits into
PrestaShop:devfrom
deepankar321:dev
Open

Updation in producttooltip.php#6
deepankar321 wants to merge 4 commits into
PrestaShop:devfrom
deepankar321:dev

Conversation

@deepankar321
Copy link
Copy Markdown

@deepankar321 deepankar321 commented Mar 24, 2015

[+] MO : in producttooltip module we can see number of cusomers who added product to a cart

@deepankar3210
producttooltip.php updation
5d67bcb 
hey,
here i have added one more configuration in this file to show number of people added product on their cart and how many people watching this at that moment . it will be helpful to show product popularity direct to customer .
i have mentioned " /*added by me */ " comment whereever i have changed the code.
This was referenced May 12, 2015
Closed
Closed
@maximebiloe
Copy link
Copy Markdown
Contributor

maximebiloe commented May 12, 2015

Hello,

Thanks for your contribution.
In order to merge your PR, could you remove all the comments you've added, please ?
Also, on line 180, are you sure you want to use 'date_addPS_PTOOLTIP_DATE_CART' and not 'date_add' ?

Could you make the modifications and update your PR, please ?

Best regards

@deepankar3210
[+] MO : show number of customers who added product to a cart
b849bc1 
producttooltip now can show number customer who have added particular product in their cart through this updation.

Thanks & Regards,
Deepankar
@deepankar321
Copy link
Copy Markdown
Author

deepankar321 commented May 12, 2015

Hello ,
Thanks for reply.
I have recently modified this file and deleted all comment added by me and yeah that was mistake ('date_addPS_PTOOLTIP_DATE_CART') , actually it is only 'date_add'

Best Regards.

@maximebiloe
Copy link
Copy Markdown
Contributor

maximebiloe commented May 12, 2015

Hello,

There are still some comments "added by me". Can you remove them, please ?

Thanks in advance.
Best regards.

@deepankar321
Copy link
Copy Markdown
Author

deepankar321 commented May 12, 2015

I am really sorry for mistakes. I didn't notice that my PR is for master.
now i have done this .
Please check it in dev branch.

Thanks & Regards

p.s. hope so this time there will be no other mistakes.

@maximebiloe
Copy link
Copy Markdown
Contributor

maximebiloe commented May 13, 2015

Hello,

It looks fine but I think you forgot to modify producttooltip.tpl file. Indeed, the cart_people element is not used in the tpl, so it's not displayed.
Could you please update your commit and your PR ?

Thanks in advance.
Regards.

@deepankar3210
[-] MO : added cart_people element in tpl
5b11d1a 
in producttooltip module we can see number of customers who added product to a cart
@deepankar321
Copy link
Copy Markdown
Author

deepankar321 commented May 13, 2015

hello
I've just updated tpl file of productooltip.

Thanks & Regards

@AlexEven AlexEven assigned AlexEven and maximebiloe and unassigned AlexEven and maximebiloe May 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement pending wording review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deepankar321 @maximebiloe @AlexEven @deepankar3210