BO: Hide raw exception on state delete failure

[mattiaclementi]

Questions	Answers
Branch?	develop
Description?	Handle DeleteStateException::FAILED_DELETE in the State BO controller to avoid exposing raw exception messages. Add an integration test ensuring an error flash is shown when delete fails.
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
How to test?	1) In BO go to International > Locations > States, try to delete a state linked to an address, and verify the flash error is An error occurred while deleting the object. (no raw exception message) 2) Run php vendor/bin/phpunit tests/Integration/PrestaShopBundle/Controller/Admin/Improve/International/StateControllerTest.php
UI Tests	Not run (not applicable).
Fixed issue or discussion?	Resolve #39761
Related PRs	N/A
Sponsor company	N/A

[ps-jarvis]

Hello @mattiaclementi!

This is your first pull request on PrestaShop repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

[Touxten]

Thanks you, I launched the CI.
It's much clearer for an e-merchant.
What do you think about explaining why this state cannot be deleted in the error message?

That way, the e-merchant won't try a second or third time...

[Touxten]

cc @kpodemski for wording

[ps-jarvis]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Admin.Notifications.Error
  • This state cannot be deleted because it is used in at least one address.

(Note: this is an automated message, but answering it will reach a real human)

[mattiaclementi]

Thanks you, I launched the CI. It's much clearer for an e-merchant. What do you think about explaining why this state cannot be deleted in the error message?

That way, the e-merchant won't try a second or third time...

It is a good idea, i've change the message to be much clearer.
Thank you.

[Hlavtox]

Guys, this is not proper, the state can be deleted from multiple reasons, not only because the state is used.

The exception must be universal.

If needed, you can throw different exceptions with different messages. 👍

[mattiaclementi]

Guys, this is not proper, the state can be deleted from multiple reasons, not only because the state is used.

The exception must be universal.

If needed, you can throw different exceptions with different messages. 👍

You're right! Sorry, I deleted the last commit, so the message is generic again.

[jolelievre]

The integration test is maybe a bit overkill for such improvement But thank you for the accuracy

[SiraDIOP]

Hello @mattiaclementi,

Thank you for your PR, I've tested this locally and everything looks good. However, I'm unable to approve the merge yet as the CI checks are still pending. I'll approve them and we'll see if everything passes! 🙂

Enregistrement.de.l.ecran.2026-02-26.a.19.16.54.mov

Thank you

[mattiaclementi]

Hello @mattiaclementi,

Thank you for your PR, I've tested this locally and everything looks good. However, I'm unable to approve the merge yet as the CI checks are still pending. I'll approve them and we'll see if everything passes! 🙂

Enregistrement.de.l.ecran.2026-02-26.a.19.16.54.mov
Thank you

Hi @SiraDIOP, i've force push a commit with the fix for header of tests/Integration/PrestaShopBundle/Controller/Admin/Improve/International/StateControllerTest.php file.
Now CI should pass without problems.
Thank you.

[kpodemski]

Hello @mattiaclementi

The only thing missing is to fix the license header in the test file you added. We've recently changed the format of the license header and added a CI checks for it.

[mattiaclementi]

Hello @mattiaclementi

The only thing missing is to fix the license header in the test file you added. We've recently changed the format of the license header and added a CI checks for it.

Hello @kpodemski
I've commit the fix for license header, my repo workflow is green now.
Thank you.