Fix that ViFindBrace doesn't search for brace when current char is not a brace

[sharpchen]

PR Summary

Vi searches right pair of first left brace, or first right brace when current char is not a brace. This pr added this functionality.

After the update, ViGotoBrace should work like this(of course this will also affect other methods such as ViDeleteBrace):

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure you've added one or more new tests
• Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed at PowerShell-Docs
    • Doc Issue filed:

Microsoft Reviewers: Open in CodeFlow

[Aston32]

S

[andyleejordan]

You are right that's how it works. I'm hoping we can do two things: verify the order of precedence in vanilla Vi (I was playing around trying to determine it and couldn't make heads or tails of it), and add some unit tests. Thanks! Love the fix though.

[sharpchen]

verify the order of precedence in vanilla Vi

Not sure what it means? If you mean the standard behavior, :h % documented the expected behavior in vim:

Find the next item in this line after or under the cursor and jump to its match.

And :h cpo-% described how the Vi behavior differs the way of Vim enhanced:

Parens inside single and double quotes are also counted, causing a string that contains a paren to disturb the matching. For example, in a line like "if (strcmp("foo(", s))" the first paren does not match the last one.

It indeed requires some tests. I did find at least one inconsistent behavior.

[sharpchen]

Hi @andyleejordan. I've rewrote the implementation, I think it's now good to go.
But I fail to run the test using ./build.ps1 -Test, it seems test/MovementTest.VI.cs is ignored? Tests pass even on false conditions.

[andyleejordan]

The rare great use of goto

[andyleejordan]

I'm not sure but if this build is like others (looking at PSScriptAnalyzer right now), -Test won't rebuild so you have to run ./build.ps1 after any change and then follow it with ./build.ps1 -Test.

AppVeyor is at least running tests, looks like Test.en_US_Windows.ViGotoBrace and Test.ScreenReader.ViGotoBrace need to be checked and updated.

[sharpchen]

Looks like tests are only available on Windows.

Shouldn't call ReadKey when there are no more keys

I honestly have no idea why test's failing. There's is a input but claims no key.

[andyleejordan]

Looks like tests are only available on Windows.

I forgot about that but yes this is unfortunately true.