nix: add postgrest-with-oriole-17#4845
nix: add postgrest-with-oriole-17#4845wolfgangwalther wants to merge 1 commit intoPostgREST:mainfrom
Conversation
| create index bets_data_json on bets ((data_json ->>'contractId')); | ||
| -- TODO orioledb: Could not identify a comparison function for type json | ||
| -- create index bets_data_json on bets ((data_json ->>'contractId')); | ||
| create index bets_data_jsonb on bets ((data_jsonb ->>'contractId')); |
There was a problem hiding this comment.
This is also worth noting, had to uncomment that line, otherwise loading the fixtures would have errored out. Some test failures are possibly related to this.
There was a problem hiding this comment.
Looks like this causes quite a few spec test failures, judging by the regular PG version spec tests failing. So this should probably be fixed first to see what else remains.
There was a problem hiding this comment.
Can repro locally all the oriole failed tests on CI.
Finished in 63.4601 seconds
1315 examples, 57 failures, 1 pending
Opened another obvious bug on orioledb/orioledb#837, it looks there are others but they would need to solve orioledb/orioledb#836 first otherwise it's hard to pinpoint.
16299bb to
717f0b4
Compare
717f0b4 to
50a6046
Compare
|
Can repro the same results as on CI locally: https://github.com/PostgREST/postgrest/actions/runs/24987776179/job/73165340783?pr=4845 |
Tests PostgREST against orioledb, which is packaged on a temporary branch on my Nixpkgs fork. Thus, not ready for merging, yet.
We will be able to see some failing spec tests, though - did not check the other test suites, yet.