feat: start and stop integrations on opt out

[MohitMandalia]

💡 Motivation and Context

Closes #242

💚 How did you test it?

• Wrote unit tests
• Ran the app.

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• I updated the docs if needed.
• No breaking change or entry added to the changelog.

If releasing new changes

• Ran pnpm changeset to generate a changeset file
• Added the "release" label to the PR to indicate we're publishing new versions for the affected packages

[marandaneto]

not all integrations should be uninstalled/installed again
PostHogAppInstallIntegration will capture another event if installed again, which should not.
PostHogLifecycleObserverIntegration cannot be uninstalled otherwise the lastUpdatedSession wont be updated
there are more cases like this, i think this issue is a bit more complicated than that

[MohitMandalia]

not all integrations should be uninstalled/installed again
PostHogAppInstallIntegration will capture another event if installed again, which should not.
PostHogLifecycleObserverIntegration cannot be uninstalled otherwise the lastUpdatedSession wont be updated
there are more cases like this, i think this issue is a bit more complicated than that

Yup got it, no worries I will take some time to read through and discuss until its ready.

[MohitMandalia]

not all integrations should be uninstalled/installed again PostHogAppInstallIntegration will capture another event if installed again, which should not. PostHogLifecycleObserverIntegration cannot be uninstalled otherwise the lastUpdatedSession wont be updated there are more cases like this, i think this issue is a bit more complicated than that

A similar concern must be for iOS as well PostHog/posthog-ios#280 if not better to check maybe.

[MohitMandalia]

@marandaneto Can we define the main goal of this PR?

Based on what I think there are few implementations which should not be uninstalled:

Ok to Uninstall:

• ReplayIntegration
• SurveysIntegration
• ErrorTrackingAutoCapture

should not Uninstall:

• ActivityLifecycleCallback
• LogCat
• SendCachedEvents
• AppInstalled
• LifecycleObserver

[marandaneto]

@marandaneto Can we define the main goal of this PR?

Based on what I think there are few implementations which should not be uninstalled:

Ok to Uninstall:

• ReplayIntegration
• SurveysIntegration
• ErrorTrackingAutoCapture

should not Uninstall:

• ActivityLifecycleCallback
• LogCat
• SendCachedEvents
• AppInstalled
• LifecycleObserver

sorry busy with other things this week, will take a look next week
you dont necessarily need to uninstall but stop to consume resources if its not going to be used
you can check one by one and see "does this need to be running if the SDK is not capturing any event anyway?"

[MohitMandalia]

@marandaneto Can we define the main goal of this PR?
Based on what I think there are few implementations which should not be uninstalled:
Ok to Uninstall:

• ReplayIntegration
• SurveysIntegration
• ErrorTrackingAutoCapture

should not Uninstall:

• ActivityLifecycleCallback
• LogCat
• SendCachedEvents
• AppInstalled
• LifecycleObserver

sorry busy with other things this week, will take a look next week you dont necessarily need to uninstall but stop to consume resources if its not going to be used you can check one by one and see "does this need to be running if the SDK is not capturing any event anyway?"

No worries take your time. I would be posting whatever questions I have.

• what exactly is the difference between stop and uninstall? other than the main class reference and integrated boolean coz in both stop and uninstall we might release the resources. Just asking to get some context.

[ioannisj]

not all integrations should be uninstalled/installed again PostHogAppInstallIntegration will capture another event if installed again, which should not. PostHogLifecycleObserverIntegration cannot be uninstalled otherwise the lastUpdatedSession wont be updated there are more cases like this, i think this issue is a bit more complicated than that

A similar concern must be for iOS as well PostHog/posthog-ios#280 if not better to check maybe.

@MohitMandalia iOS is okay for PostHogAppInstallIntegration since we depend on a static var to avoid capturing duplicate events.
SessionManager doesn't depend on an integration for managing session, so all good there

[MohitMandalia]

I will also try to close this soon

[MohitMandalia]

@marandaneto what exactly is the difference between stop and uninstall? other than the main class reference and integrated boolean coz in both stop and uninstall we might release the resources. Just asking to get some context.

[marandaneto]

@marandaneto what exactly is the difference between stop and uninstall? other than the main class reference and integrated boolean coz in both stop and uninstall we might release the resources. Just asking to get some context.

i see uninstall as a when somebody calls eg sdk.close() which is not meant to be usable anymore in that process, clear all resources

stop is like ok stop for now eg (sdk.optOut()) and later on resume with sdk.optIn() or eg the app is in the background, no need to keep using resources, but only when the app is back in the foreground

[MohitMandalia]

@marandaneto what exactly is the difference between stop and uninstall? other than the main class reference and integrated boolean coz in both stop and uninstall we might release the resources. Just asking to get some context.

i see uninstall as a when somebody calls eg sdk.close() which is not meant to be usable anymore in that process, clear all resources

stop is like ok stop for now eg (sdk.optOut()) and later on resume with sdk.optIn() or eg the app is in the background, no need to keep using resources, but only when the app is back in the foreground

so we might need to add start() and stop() to the PostHogIntegration.

Few points:

• Would adding start stop be ok for parity of sdk across platforms bcoz same behavior should be replicated across platforms?
• And here stopping vs uninstall is like we do not remove reference to posthog and few important things for a particular integration but we try to clear unwanted things.

WDYT