Skip to content

feat: Implement permissions sorting #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewjmcgehee wants to merge 2 commits into from
Closed

feat: Implement permissions sorting #650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85093a5
change sorting of allow options in twig
andrewjmcgehee Jan 27, 2026
08cfebe
reorder
andrewjmcgehee Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions apps/twig/src/renderer/features/sessions/components/InlinePermissionSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,17 @@ import { Box, Flex, Text } from "@radix-ui/themes";
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useHotkeys } from "react-hotkeys-hook";

export type PermissionOptionKind =
| "allow_once"
| "allow_always"
| "custom"
| "reject_once";

export interface PermissionOption {
optionId: string;
name: string;
description?: string;
kind: string;
kind: PermissionOptionKind;
}

interface InlinePermissionSelectorProps {
Expand All @@ -29,6 +35,12 @@ export function InlinePermissionSelector({
const [customInput, setCustomInput] = useState("");
const inputRef = useRef<HTMLInputElement>(null);
const containerRef = useRef<HTMLDivElement>(null);
const sortPriority: Record<PermissionOptionKind, number> = {
allow_once: 500,
allow_always: 400,
reject_once: 300,
custom: 100,
};

// Auto-focus the container when component mounts to capture keyboard events
useEffect(() => {
Expand Down Expand Up @@ -57,7 +69,10 @@ export function InlinePermissionSelector({
{ optionId: "_custom", name: "Other", description: "", kind: "custom" },
];
}
return filteredOptions;
// sorts so that higher priority comes first (ie descending order)
return filteredOptions.sort(
(a, b) => sortPriority[b.kind] - sortPriority[a.kind],
);
}, [options]);

const numOptions = allOptions.length;
Expand Down
Loading