fix: properly shutdown all services using preDestroy and unbindAll#646
Merged
jonathanlab merged 1 commit intomainfrom Jan 27, 2026
Merged
fix: properly shutdown all services using preDestroy and unbindAll#646jonathanlab merged 1 commit intomainfrom
jonathanlab merged 1 commit intomainfrom
Conversation
k11kirky
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not properly cleaning up all services on
lifecycleService.shutdownThis caused auto updates, CMD-Q, etc to break, because we'd have lingering services such as file watchers etc.
I've made it so that each stateful service has a
@preDestroynow.LifecycleServicenow callsunbindAllinstead of destroying individual services. This in turn triggers@preDestroy