feat(code): allow users to record custom notification sounds#1629
Draft
feat(code): allow users to record custom notification sounds#1629
Conversation
Add the ability for users to record their own notification sound via microphone directly from the settings UI. The recording is stored locally in the app's userData directory. - Add saveCustomSound/getCustomSoundDataUrl/deleteCustomSound tRPC endpoints - Add "custom" option to CompletionSound type - Add SoundRecorder component with permission, record, preview, save flow - Update sounds.ts to handle custom sound playback with cached data URL - Auto-detect existing mic permission to skip the allow step Generated-By: PostHog Code Task-Id: d0ceb2b8-f72e-4cda-a1ee-b1423e3d66a3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users can only pick from a fixed set of 11 bundled notification sounds. Some users (me) want to set a custom sound that's personal or more noticeable to them.
Changes
"custom"to theCompletionSoundunion typesaveCustomSound/getCustomSoundDataUrl/deleteCustomSoundtRPC endpoints that store recordings in{userData}/sounds/custom-sound.webmSoundRecordercomponent with a 4-state flow: permission → ready → recording (5s max) → recorded (play/save/discard)sounds.tsto handle custom sound playback with a lazily-loaded cached data URLHow did you test this?
Created with PostHog Code