Skip to content

fix: Fix session race condition killing active agents and retry loop#1627

Merged
charlesvien merged 1 commit intomainfrom
04-13-fix_session_race_condition_killing_active_agents_and_retry_loop
Apr 14, 2026
Merged

fix: Fix session race condition killing active agents and retry loop#1627
charlesvien merged 1 commit intomainfrom
04-13-fix_session_race_condition_killing_active_agents_and_retry_loop

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 13, 2026

Problem

Fix session race condition killing active agents and retry loop.

Changes

  1. Scope process cleanup to the current taskRunId instead of killing all agent/child processes for the task
  2. Clear initialPrompt on session error to prevent retry loops

How did you test this?

Manually

Copy link
Copy Markdown
Member Author

charlesvien commented Apr 13, 2026

@charlesvien charlesvien changed the title Fix session race condition killing active agents and retry loop fix: Fix session race condition killing active agents and retry loop Apr 13, 2026
@charlesvien charlesvien force-pushed the 04-13-fix_session_race_condition_killing_active_agents_and_retry_loop branch from ba99774 to e8a5394 Compare April 13, 2026 19:50
@charlesvien charlesvien marked this pull request as ready for review April 13, 2026 20:03
@charlesvien charlesvien changed the base branch from 04-13-first-session-nits to graphite-base/1627 April 14, 2026 02:18
@charlesvien charlesvien force-pushed the 04-13-fix_session_race_condition_killing_active_agents_and_retry_loop branch from e8a5394 to 5ce29d3 Compare April 14, 2026 02:18
@graphite-app graphite-app bot changed the base branch from graphite-base/1627 to main April 14, 2026 02:19
Copy link
Copy Markdown
Contributor

adboio commented Apr 14, 2026

is this possibly related to my poorly written issue here? #1602

@charlesvien charlesvien force-pushed the 04-13-fix_session_race_condition_killing_active_agents_and_retry_loop branch from 5ce29d3 to d40275c Compare April 14, 2026 02:19
@charlesvien charlesvien merged commit 87c5cce into main Apr 14, 2026
16 checks passed
Copy link
Copy Markdown
Member Author

Merge activity

@charlesvien charlesvien deleted the 04-13-fix_session_race_condition_killing_active_agents_and_retry_loop branch April 14, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants