Skip to content

chore(code): disable terminal tabs for cloud run#1553

Merged
VojtechBartos merged 2 commits intomainfrom
vojta/cloud-disabled-terminal
Apr 8, 2026
Merged

chore(code): disable terminal tabs for cloud run#1553
VojtechBartos merged 2 commits intomainfrom
vojta/cloud-disabled-terminal

Conversation

@VojtechBartos
Copy link
Copy Markdown
Member

Problem

Terminal doesn't work for cloud rins. The terminal tab and inline bash commands (! command) are local-only features that shouldn't be available for cloud runs. Currently the terminal tab renders but shows nothing useful, the "+" button lets users add more empty terminal tabs, and typing ! command is silently dropped instead of being sent as a normal prompt.

Changes

  • Terminal tabs hidden for cloud runsLeafNodeRenderer filters out terminal tabs before they reach useTabInjection, so no TabContentRenderer or shell process is ever created. The "+" add terminal button is also hidden. If the active tab was a terminal, it falls back to the first available tab.
  • Inline bash mode disabled for cloud runsMessageEditor uses a new useIsWorkspaceCloudRun hook to set capabilities.bashMode to false, which disables the ! prefix visual indicator (blue ring). The submit function now also checks enableBashMode before routing ! text to the bash handler, so ! text is submitted as a normal prompt instead of being silently dropped.
  • New useIsWorkspaceCloudRun hook — Thin wrapper around useWorkspace that returns workspace?.mode === "cloud", used by both LeafNodeRenderer and MessageEditor to avoid prop drilling.

How did you test this?

  • pnpm typecheck — all 9 packages pass
  • pnpm lint — no new warnings
  • pnpm --filter code test — 584/584 tests pass

@VojtechBartos VojtechBartos self-assigned this Apr 8, 2026
@VojtechBartos VojtechBartos requested a review from a team April 8, 2026 14:09
@VojtechBartos VojtechBartos force-pushed the vojta/cloud-disabled-terminal branch from 71bc964 to cc19802 Compare April 8, 2026 14:10
@VojtechBartos VojtechBartos enabled auto-merge (squash) April 8, 2026 14:15
@VojtechBartos VojtechBartos merged commit a19fe26 into main Apr 8, 2026
15 checks passed
@VojtechBartos VojtechBartos deleted the vojta/cloud-disabled-terminal branch April 8, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants