Skip to content

fix: Stop renderer from overriding plan approval permission mode#1523

Merged
charlesvien merged 4 commits intomainfrom
04-07-stop_renderer_from_overriding_plan_approval_permission_mode
Apr 7, 2026
Merged

fix: Stop renderer from overriding plan approval permission mode#1523
charlesvien merged 4 commits intomainfrom
04-07-stop_renderer_from_overriding_plan_approval_permission_mode

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 7, 2026

Problem

Selecting "Yes, auto-accept all permissions" on plan approval enters default mode instead of bypass because the renderer overwrites the agent's mode setting.

Closes #1502

Changes

  1. Skip generic "acceptEdits" override in handlePermissionSelect for switch_mode permissions (plan approval manages its own mode via the agent)
  2. Cleanup useEffect that reverted bypass mode whenever allowBypassPermissions was false.

How did you test this?

Manually

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@charlesvien charlesvien changed the title Stop renderer from overriding plan approval permission mode fix: Stop renderer from overriding plan approval permission mode Apr 7, 2026
@charlesvien charlesvien marked this pull request as ready for review April 7, 2026 15:17
@charlesvien charlesvien merged commit fee2ace into main Apr 7, 2026
16 checks passed
@charlesvien charlesvien deleted the 04-07-stop_renderer_from_overriding_plan_approval_permission_mode branch April 7, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Yes, auto-accept all permissions" not working correctly

2 participants