Skip to content

fix: Fix model selection lost during task creation#1437

Merged
charlesvien merged 3 commits intomainfrom
04-01-model-selector-broken
Apr 2, 2026
Merged

fix: Fix model selection lost during task creation#1437
charlesvien merged 3 commits intomainfrom
04-01-model-selector-broken

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 2, 2026

Problem

Model selected in the new task input was silently dropped. The session always started with the default model because selection was applied as a post start config patch that raced with the first prompt.

Closes #1380

Closes #1340

Changes

  1. Pass selected model through the start session schema all the way to the SDK
  2. Fetch model config in parallel with SDK initialization for new sessions
  3. Remove post start config patching that raced with first prompt delivery
  4. Limit useSessionConnection to reconnects only, new sessions handled by task creation saga

How did you test this?

Manually

Copy link
Copy Markdown
Member Author

charlesvien commented Apr 2, 2026

@charlesvien charlesvien changed the title Fix model selection lost during task creation fix: Fix model selection lost during task creation Apr 2, 2026
@charlesvien charlesvien marked this pull request as ready for review April 2, 2026 04:12
@charlesvien charlesvien changed the base branch from 04-01-persist_new_task_draft_across_navigation to graphite-base/1437 April 2, 2026 05:12
@jonathanlab jonathanlab force-pushed the 04-01-model-selector-broken branch from 5f29f86 to ff2787d Compare April 2, 2026 11:23
@jonathanlab jonathanlab changed the base branch from graphite-base/1437 to main April 2, 2026 11:23
Copy link
Copy Markdown
Contributor

jonathanlab commented Apr 2, 2026

Merge activity

  • Apr 2, 11:50 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 2, 12:12 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

@charlesvien charlesvien merged commit d217434 into main Apr 2, 2026
11 of 16 checks passed
@charlesvien charlesvien deleted the 04-01-model-selector-broken branch April 2, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selected model during task creation does not persist Model selection not working for Codex(OpenAI) based models

3 participants