Skip to content

fix: Replace mock node symlink with wrapper script#1404

Closed
charlesvien wants to merge 3 commits intomainfrom
03-31-fix-zombie-tim
Closed

fix: Replace mock node symlink with wrapper script#1404
charlesvien wants to merge 3 commits intomainfrom
03-31-fix-zombie-tim

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 1, 2026

Problem

The mock node environment used a symlink from node → Electron binary, but ELECTRON_RUN_AS_NODE wasn't set for grandchild processes (e.g. node -v from the SDK).

This caused full Electron instances to spawn instead of running as Node.js, triggering thousands of second-instance events and zombie processes.

Changes

  1. Replace symlink with a shell wrapper script that exports ELECTRON_RUN_AS_NODE=1
  2. Clean up existing symlink before writing the wrapper
  3. Make wrapper executable with chmod 755

How did you test this?

Manually

@charlesvien charlesvien changed the title Use focusMainWindow fix: Replace mock node symlink with wrapper script Apr 1, 2026
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@charlesvien charlesvien closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant