fix: render branch creation dialog in TaskInput screen#1326
Merged
k11kirky merged 3 commits intoPostHog:mainfrom Mar 31, 2026
Merged
fix: render branch creation dialog in TaskInput screen#1326k11kirky merged 3 commits intoPostHog:mainfrom
k11kirky merged 3 commits intoPostHog:mainfrom
Conversation
Contributor
Author
|
Hi @charlesvien , I submitted this PR to fix #1205. The "Create new branch" dialog wasn't rendering on the Happy to hear your thoughts when you have time. Thanks! |
46f1840 to
5be495c
Compare
jonathanlab
approved these changes
Mar 31, 2026
Contributor
jonathanlab
left a comment
There was a problem hiding this comment.
This is great, thanks a lot! @k11kirky will reach out to soon about sending some merch your way for all these PRs!
charlesvien
approved these changes
Mar 31, 2026
1589103 to
3237a17
Compare
3237a17 to
9b4d221
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BranchSelectorcomponent of the TaskInput page, nothing happens because theGitBranchDialogis never rendered in this flow.Closes #1205
Changes
GitBranchDialogcomponent to theTaskInputscreenuseGitInteractionStoreprops)branch-heretoGitActionTypeto fix linter issuebranchCreationutility used by both TaskInput and useGitInteraction (no intended behavior change).How did you test this?
apps/code/src/renderer/features/git-interaction/utils/branchCreation.test.ts