Local gateway + Ollama code example broken — base_url missing /v1 — Epic Games#812
Local gateway + Ollama code example broken — base_url missing /v1 — Epic Games#812anshulbasia27 wants to merge 2 commits intomainfrom
Conversation
|
@Cursor-AI Please review this PR. ContextThis PR was automatically generated by Altor to address a customer-reported product gap for Epic Games.
RequirementLocal gateway + Ollama code example broken — base_url missing /v1 Acceptance CriteriaPlease verify each of the following is satisfied by the implementation:
ReferencesReview Focus
Please call out anything that looks incomplete or incorrect before this is merged. |
akhilmmenon
left a comment
There was a problem hiding this comment.
Reviewed integrations/llms/ollama.mdx against the issue context in [#812]
Looks good and meets the stated acceptance criteria:
Local setup now correctly uses base_url / baseURL with /v1 (http://localhost:8787/v1), which fixes the reported local gateway failure.
Node.js example is present alongside Python for parity.
The note clearly distinguishes:
custom_host / customHost (Ollama URL, without /v1)
base_url / baseURL (local Portkey gateway URL, with /v1)
I don’t see regressions in the updated examples.
Non-blocking note: runtime execution wasn’t re-verified in this review pass; this is a content/accuracy validation.
Summary
Fix broken code example in the Ollama local setup docs. The
base_urlparameter was missing the required/v1path suffix, causing SDK errors when connecting to a local Portkey gateway.What changed
integrations/llms/ollama.mdx:base_urlfromhttp://localhost:8787tohttp://localhost:8787/v1in the Local Setup Python example<CodeGroup>)<Note>block at the bottom of the page to distinguish betweencustom_host(Ollama URL, no/v1) andbase_url(gateway URL, requires/v1)Customer context
Reported by Epic Games. The customer provided screenshots showing:
base_urlincludes/v1(successful chat completion via Ollama)/v1is omittedAcceptance criteria
base_urlin Local Setup example includes/v1<Note>block clarified to avoid confusion betweencustom_hostandbase_url