Skip to content

Remove default implementation of load_with_config#2521

Merged
ljeub-pometry merged 2 commits intodb_v4from
db_v4_/fix-wal-config
Mar 16, 2026
Merged

Remove default implementation of load_with_config#2521
ljeub-pometry merged 2 commits intodb_v4from
db_v4_/fix-wal-config

Conversation

@fabubaker
Copy link
Copy Markdown
Contributor

@fabubaker fabubaker commented Mar 13, 2026

What changes were proposed in this pull request?

Removes the current implementation of load_with_config in favor of the changes in https://github.com/Pometry/pometry-storage/pull/196.

Why are the changes needed?

To fix https://github.com/Pometry/pometry-storage/issues/195.

Does this PR introduce any user-facing change? If yes is this documented?

No.

How was this patch tested?

Added a unit test in https://github.com/Pometry/pometry-storage/pull/196 to see if the config is correctly used on Graph.load.

Are there any further changes required?

No.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: f20f512 Previous: 0a57b32 Ratio
graphgen_large_clustering_coeff/graphgen_large_clustering_coeff/Graph(num_nodes=500004, num_edges=20... 7145218599 ns/iter (± 74340141) 3492908111 ns/iter (± 59672478) 2.05
large/1k random edge additions 1153976 ns/iter (± 145548) 501916 ns/iter (± 37382) 2.30
large/1k random edge additions with numeric string input 1695011 ns/iter (± 161290) 718472 ns/iter (± 45939) 2.36
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 393 ns/iter (± 1) 1 ns/iter (± 0) 393
lotr_graph/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 9555833 ns/iter (± 442011) 1516222 ns/iter (± 37463) 6.30
lotr_graph_window_100/num_edges 28 ns/iter (± 0) 8 ns/iter (± 0) 3.50
lotr_graph_window_100/num_nodes 384 ns/iter (± 2) 5 ns/iter (± 0) 76.80
lotr_graph_window_100/has_node_existing 45 ns/iter (± 0) 22 ns/iter (± 0) 2.05
lotr_graph_window_100/iterate nodes 10176 ns/iter (± 33) 4323 ns/iter (± 22) 2.35
lotr_graph_window_100_materialise/materialize 9885108 ns/iter (± 90769) 1642110 ns/iter (± 5862) 6.02
lotr_graph_window_10/has_node_existing 145 ns/iter (± 9) 62 ns/iter (± 12) 2.34
lotr_graph_window_10/iterate nodes 37819 ns/iter (± 377) 11923 ns/iter (± 36) 3.17
lotr_graph_window_10/iterate edges 119036 ns/iter (± 192) 47346 ns/iter (± 181) 2.51
lotr_graph_window_10_materialise/materialize 7184764 ns/iter (± 76045) 1009574 ns/iter (± 4555) 7.12
lotr_graph_subgraph_10pc/has_edge_existing 256 ns/iter (± 7) 91 ns/iter (± 1) 2.81
lotr_graph_subgraph_10pc/num_nodes 355 ns/iter (± 2) 4 ns/iter (± 0) 88.75
lotr_graph_subgraph_10pc/has_node_existing 110 ns/iter (± 2) 34 ns/iter (± 0) 3.24
lotr_graph_subgraph_10pc/iterate nodes 3056 ns/iter (± 6) 838 ns/iter (± 3) 3.65
lotr_graph_subgraph_10pc_windowed/has_node_existing 142 ns/iter (± 7) 62 ns/iter (± 13) 2.29
lotr_graph_subgraph_10pc_windowed/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_subgraph_10pc_windowed/iterate nodes 4894 ns/iter (± 10) 1411 ns/iter (± 3) 3.47
lotr_graph_window_50_layered/num_edges 91764 ns/iter (± 5924) 45447 ns/iter (± 520) 2.02
lotr_graph_window_50_layered/num_edges_temporal 155904 ns/iter (± 6430) 76900 ns/iter (± 1861) 2.03
lotr_graph_window_50_layered/num_nodes 79820 ns/iter (± 2793) 27243 ns/iter (± 857) 2.93
lotr_graph_window_50_layered/has_node_existing 1121 ns/iter (± 100) 132 ns/iter (± 14) 8.49
lotr_graph_window_50_layered/max_id 89792 ns/iter (± 2786) 32031 ns/iter (± 568) 2.80
lotr_graph_window_50_layered/iterate nodes 148299 ns/iter (± 1558) 20300 ns/iter (± 80) 7.31
lotr_graph_window_50_layered/iterate edges 243725 ns/iter (± 3219) 86825 ns/iter (± 269) 2.81
lotr_graph_window_50_layered/max_neighbour_degree 848262 ns/iter (± 1771) 394035 ns/iter (± 2530) 2.15
lotr_graph_window_50_layered/graph_latest 126841 ns/iter (± 4973) 43315 ns/iter (± 4961) 2.93
lotr_graph_window_50_layered_materialise/materialize 26577479 ns/iter (± 536511) 3480284 ns/iter (± 27402) 7.64
lotr_graph_persistent_window_50_layered/num_edges_temporal 641488 ns/iter (± 5898) 200192 ns/iter (± 4420) 3.20
lotr_graph_persistent_window_50_layered/num_nodes 98075 ns/iter (± 1453) 36857 ns/iter (± 3502) 2.66
lotr_graph_persistent_window_50_layered/has_node_existing 1224 ns/iter (± 190) 201 ns/iter (± 77) 6.09
lotr_graph_persistent_window_50_layered/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_persistent_window_50_layered/max_id 111531 ns/iter (± 9556) 44331 ns/iter (± 2452) 2.52
lotr_graph_persistent_window_50_layered/iterate nodes 197999 ns/iter (± 2441) 37870 ns/iter (± 121) 5.23
lotr_graph_persistent_window_50_layered/iterate edges 216241 ns/iter (± 1596) 87950 ns/iter (± 576) 2.46
lotr_graph_persistent_window_50_layered/graph_latest 188952 ns/iter (± 6263) 63522 ns/iter (± 2421) 2.97
lotr_graph_persistent_window_50_layered_materialise/materialize 56035603 ns/iter (± 314028) 5265571 ns/iter (± 39509) 10.64
lotr_graph/proto_decode 11236798 ns/iter (± 571734) 1923641 ns/iter (± 47248) 5.84
lotr_graph/proto_encode 9324915 ns/iter (± 212133) 1219979 ns/iter (± 67210) 7.64

This comment was automatically generated by workflow using github-action-benchmark.

@ljeub-pometry ljeub-pometry merged commit 39c1447 into db_v4 Mar 16, 2026
2 checks passed
@ljeub-pometry ljeub-pometry deleted the db_v4_/fix-wal-config branch March 16, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants