Changed Various Fields in card.py and set.py to be optional#19
Open
Rwelk wants to merge 1 commit intoPokemonTCG:masterfrom
Open
Changed Various Fields in card.py and set.py to be optional#19Rwelk wants to merge 1 commit intoPokemonTCG:masterfrom
card.py and set.py to be optional#19Rwelk wants to merge 1 commit intoPokemonTCG:masterfrom
Conversation
For some reason, there are a bunch of fields in card.py and set.py that are not optional. This becomes an issue when using where() with the select keyword, as those fields are required in the select. I don't know how to make tests, so no clue if this change will break anything. I also left the id fields as-is, in case they're necessary for something else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, there are a bunch of fields in
card.pyandset.pythat are not optional. This becomes an issue when usingwhere()with theselectkeyword, as those fields are required in the select. I don't know how to make tests, so no clue if this change will break anything. I also left the id fields as-is, in case they're necessary for something else.