Max Lair - Added the option to stop on Alolan Raichu and Alolan Marowak#1110
Open
Boombaastical wants to merge 5 commits intoPokemonAutomation:mainfrom
Open
Max Lair - Added the option to stop on Alolan Raichu and Alolan Marowak#1110Boombaastical wants to merge 5 commits intoPokemonAutomation:mainfrom
Boombaastical wants to merge 5 commits intoPokemonAutomation:mainfrom
Conversation
…ir Adventure (Alolan Raichu and Alolan Marowak)
…r adventure (Alolan Raichu and Alolan Marowak)
Collaborator
|
This will probably be on hold for a while due to how invasive it is and the fact that we're all busy with FRLG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As notified two days ago over Discord, the idea is simply to be able to stop on certain pokemon encountered during the Run_Battle part, so that the change doesn't become so invasive (I also don't want to start an overhaul of the whole MaxLair program with my limited C++ knowledge).
I also left an option to include the whole list of pokemon instead of Alolan Raichu and Marowak, but since the list is rather long, I don't think it makes much sense to add the whole list by default (for developers or those who would like this function specifically, they could still change the code by changing LIMITED_MODE in Options_NonBossAction.cpp.
I tested it before with the whole list to stop on certain pokemon, and it indeed stops as needed.