Skip to content

Add missing evolution entries#1525

Open
FreakMediaLP wants to merge 2 commits into
PokeAPI:masterfrom
FreakMediaLP:add-missing-evolution-entries
Open

Add missing evolution entries#1525
FreakMediaLP wants to merge 2 commits into
PokeAPI:masterfrom
FreakMediaLP:add-missing-evolution-entries

Conversation

@FreakMediaLP
Copy link
Copy Markdown

Change description

Added missing evolution locations:

  • "New Mauville" for "Magneton" and "Probopass" (available in ORAS)
  • "Petalburg Woods" for "Leafeon" (available in ORAS)
  • "Shoal Cave" for "Glaceon" (available in ORAS)

AI coding assistance disclosure

Used AI to get a better understanding of the pokemon_evolutions.csv and its connections with other .csv files.
All changes were made manually though.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Added missing evolution location "New Mauville" for "Magneton" and "Probopass" in ORAS
Added missing evolution location "Petalburg Woods" for "Leafeon" in ORAS
Added missing evolution location "Shoal Cave" for "Glaceon" in ORAS
@Naramsim
Copy link
Copy Markdown
Member

Hi! For Leafeon I see that being close to a Moss Rock is needed for eevee to evolve. Is there a way to map this requirement?

And for Gleceon one must be at the lowest level of the cave: https://pokeapi.co/api/v2/location/445 Which in the API is a location-area. Can we also map that?

@FreakMediaLP
Copy link
Copy Markdown
Author

And for Gleceon one must be at the lowest level of the cave: https://pokeapi.co/api/v2/location/445 Which in the API is a location-area. Can we also map that?

The pokemon_evolution.csv currently has no attribute for "location_area", only "location_id". This addition or change would mean a lot of work and research, as there will most likely be more evolution chains, which would need to be updated as well.

But this might not be necessary, because as you stated, Leafeon requires sth like "close-to-moss-rock", and also Glaceon requires "close-to-ice-rock" (The "lowest level of the cave" just happens to be the area, where ice-rocks can be found).
The reason why I just added the "location_id" was, beause at the moment, every (level-up) evolution only has a "location-id" and as stated above, there is no attribute for "location-area"


Leafeon (470)

Row Trigger Condition Resolved
238 1 (level-up) location_id=8 eterna-forest
324 1 (level-up) location_id=375 pinwheel-forest
363 1 (level-up) location_id=650 kalos-route-20
407 3 (use-item) trigger_item_id=85 leaf-stone
548 1 (level-up) location_id=438 petalburg-woods ← new

Glaceon (471)

Row Trigger Condition Resolved
239 1 (level-up) location_id=48 sinnoh-route-217
325 1 (level-up) location_id=380 twist-mountain
364 1 (level-up) location_id=640 frost-cavern
408 3 (use-item) trigger_item_id=885 ice-stone
549 1 (level-up) location_id=445 shoal-cave ← new

But how should these methods be added? It wouldnt make sence to add them as a "location_id", neither as a "location-area" and at the moment, every (level-up) evolution for these two has a "location_id" mapped, so ALL of them would need to be adjusted.

How would you suggest, we should add these (level-up) methods/areas?

@jemarq04
Copy link
Copy Markdown
Member

There are only 19 location-based evolutions currently in the database. I'm familiar with updating the evolution details, so if we think it would be more descriptive I can go in after this PR and update these locations to point to the relevant location areas. That still wouldn't be able to specify things like "close-to-moss-rock", as there are no evolution conditions like there are for encounters. But I think it would be sufficient.

What do we think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants