fix(secure-storage): handle large arrays in u8ToBase64 to avoid stack overflow#61
Open
DeMonkeyCoder wants to merge 1 commit intoPlasmoHQ:mainfrom
Open
fix(secure-storage): handle large arrays in u8ToBase64 to avoid stack overflow#61DeMonkeyCoder wants to merge 1 commit intoPlasmoHQ:mainfrom
DeMonkeyCoder wants to merge 1 commit intoPlasmoHQ:mainfrom
Conversation
DeMonkeyCoder
force-pushed
the
fix/secure-storage-large-data
branch
from
4e5cd1e to
680309f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing an array with a length of around 2^16 or greater to the String.fromCharCode.apply method in a Chrome extension’s background script causes a RangeError: Maximum call stack size exceeded. In node.js and browser this limit is around 2^17. This PR addresses the stack overflow by slicing the data in u8ToBase64 into smaller chunks. Added a test case to verify large data handling in SecureStorage.