fix(room_booking_approval): [PPT-2340] improve speed of approving recurring events

drivers/place/room_booking_approval.cr

@@ -6,16 +6,21 @@ class Place::RoomBookingApproval < PlaceOS::Driver
   generic_name :RoomBookingApproval
   description %(Room Booking approval for tentative events)
 
-  default_settings({} of String => String)
+  default_settings({
+    check_recurring_event_id: false, # fetches the event to verify the provided id is the series root.
+  })
 
   accessor calendar : Calendar_1
 
+  @check_recurring_event_id : Bool = false
+
   getter building_id : String { get_building_id.not_nil! }
   getter systems : Hash(String, Array(String)) { get_systems_list.not_nil! }
 
   def on_update
     @building_id = nil
     @systems = nil
+    @check_recurring_event_id = setting?(Bool, :check_recurring_event_id) || false
 
     schedule.clear
     # used to detect changes in building configuration
@@ -87,45 +92,11 @@ class Place::RoomBookingApproval < PlaceOS::Driver
   end
 
   @[Security(Level::Support)]
-  def accept_recurring_event(calendar_id : String, recurring_event_id : String, user_id : String? = nil, period_start : Int64? = nil, period_end : Int64? = nil, notify : Bool = false, comment : String? = nil)
-    logger.debug { "accepting recurring event #{recurring_event_id} on #{calendar_id}" }
-
-    if period_start || period_end
-      # Use provided dates or default to now and 1 year ahead
-      now = Time.utc
-      start_time = period_start || now.to_unix
-      end_time = period_end || (now + 1.year).to_unix
-
-      # Find all instances of this recurring event
-      events = Array(PlaceCalendar::Event).from_json calendar.list_events(
-        calendar_id: calendar_id,
-        period_start: start_time,
-        period_end: end_time,
-        user_id: user_id,
-        include_cancelled: false
-      ).get.to_json
-      logger.debug { "Found #{events.size} events on calendar #{calendar_id}" }
-
-      recurring_instances = events.select { |event| event.recurring_event_id == recurring_event_id }
-      logger.info { "Found #{recurring_instances.size} instances of recurring event #{recurring_event_id}" }
-
-      # Accept each instance
-      accepted_count = 0
-      recurring_instances.each do |event|
-        begin
-          calendar.accept_event(calendar_id, event.id, user_id: user_id, notify: notify, comment: comment)
-          accepted_count += 1
-          logger.debug { "Accepted recurring event instance #{event.id}" }
-        rescue error
-          logger.warn(exception: error) { "Failed to accept recurring event instance #{event.id}" }
-        end
-      end
-
-      logger.info { "Accepted #{accepted_count} instances of recurring event #{recurring_event_id}" }
-    else
-      calendar.accept_event(calendar_id: calendar_id, event_id: recurring_event_id, user_id: user_id, notify: notify, comment: comment)
-    end
+  def accept_recurring_event(calendar_id : String, recurring_event_id : String, user_id : String? = nil, notify : Bool = false, comment : String? = nil)
+    recurring_event_id = resolve_recurring_event_id(calendar_id, recurring_event_id, user_id) if @check_recurring_event_id
 
+    logger.debug { "accepting recurring event #{recurring_event_id} on #{calendar_id}" }
+    calendar.accept_event(calendar_id: calendar_id, event_id: recurring_event_id, user_id: user_id, notify: notify, comment: comment)
     clear_cache(event_id: recurring_event_id)
   end
 
@@ -134,4 +105,29 @@ class Place::RoomBookingApproval < PlaceOS::Driver
     calendar.decline_event(calendar_id: calendar_id, event_id: event_id, user_id: user_id, notify: notify, comment: comment)
     clear_cache(event_id: event_id)
   end
+
+  @[Security(Level::Support)]
+  def decline_recurring_event(calendar_id : String, recurring_event_id : String, user_id : String? = nil, notify : Bool = false, comment : String? = nil)
+    recurring_event_id = resolve_recurring_event_id(calendar_id, recurring_event_id, user_id) if @check_recurring_event_id
+
+    logger.debug { "declining recurring event #{recurring_event_id} on #{calendar_id}" }
+    calendar.decline_event(calendar_id: calendar_id, event_id: recurring_event_id, user_id: user_id, notify: notify, comment: comment)
+    clear_cache(event_id: recurring_event_id)
+  end
+
+  @[Security(Level::Support)]
+  def resolve_recurring_event_id(calendar_id : String, event_id : String, user_id : String? = nil) : String
+    event_user_id = user_id || calendar_id
+    response = calendar.get_event(user_id: event_user_id, id: event_id, calendar_id: calendar_id).get
+    place_event = PlaceCalendar::Event.from_json(response.to_json)
+    if (recurring_event_id = place_event.recurring_event_id.presence) && recurring_event_id != event_id
+      logger.debug { "provided id #{event_id} is a series occurrence, not the recurring event — using recurring event id #{recurring_event_id}" }
+      recurring_event_id
+    else
+      event_id
+    end
+  rescue error
+    logger.debug(exception: error) { "unable to verify recurring event id for #{event_id}" }
+    event_id
+  end
 end