Skip to content

Procedural Drum Synthesis & "Drum Party" Implementation#56

Open
Pitrat-wav wants to merge 1 commit intomainfrom
feat/drum-party-dsp-synthesis-5090408252016786969
Open

Procedural Drum Synthesis & "Drum Party" Implementation#56
Pitrat-wav wants to merge 1 commit intomainfrom
feat/drum-party-dsp-synthesis-5090408252016786969

Conversation

@Pitrat-wav
Copy link
Copy Markdown
Owner

@Pitrat-wav Pitrat-wav commented Apr 13, 2026

This PR implements a fully synthesized drum machine based on the provided "Programmatic Synthesis of Analog Percussion" research.

Key changes:

  1. Instrument Models: TR808Kick, TR909Kick, TR808Snare, TR909Snare, TR808HiHat, and TR808Clap now support a velocity parameter. The TR909Kick was improved with a 1000Hz smoothing LPF as specified.
  2. Master Saturation: Added a WaveShaper based saturation stage to the DrumMachine using the provided soft-clipping formula. This can be controlled via a new 'DRIVE' knob in the UI.
  3. Drum Party Configuration: Set default Euclidean patterns to create an immediate rhythmic groove upon initialization.
  4. Analog Drift: Integrated micro-randomization for pitch drift, filter cutoff, and decay times to simulate analog instability.
  5. Bug Fixes: Corrected the hi-hat open volume mapping in audioStore.ts and fixed the pattern visualizer in DrumsView.tsx to correctly display rotated Euclidean patterns.

All changes verified via TypeScript type checking and visual inspection of the UI.

PR created automatically by Jules for task 5090408252016786969 started by @Pitrat-wav

@google-labs-jules @Pitrat-wav
feat: implement procedural drum synthesis based on DSP research
19fb9ae 
- Updated all TR-808 and TR-909 drum models to support velocity scaling and per-hit micro-randomization.
- Enhanced TR-909 Kick with a smoothing low-pass filter on the triangle body.
- Implemented master saturation (DRIVE) in DrumMachine using a soft-clipping tanh approximation curve.
- Configured "Drum Party" default Euclidean patterns: Kick (16/4), Snare (16/2 rot 4), Hi-Hat (16/12), Open Hat (16/2 rot 2), and Clap (16/2 rot 4).
- Added master DRIVE control to DrumsView and fixed rotated pattern visualization.
- Fixed hihatOpen output routing in audioStore for independent volume control.

Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

google-labs-jules bot commented Apr 13, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pitrat-wav