Skip to content

Procedural Drum Synthesis Humanization & Saturation#54

Open
Pitrat-wav wants to merge 1 commit intomainfrom
feature/dsp-drum-synthesis-humanization-4826691370997891434
Open

Procedural Drum Synthesis Humanization & Saturation#54
Pitrat-wav wants to merge 1 commit intomainfrom
feature/dsp-drum-synthesis-humanization-4826691370997891434

Conversation

@Pitrat-wav
Copy link
Copy Markdown
Owner

This PR implements procedural drum synthesis enhancements based on deep DSP analysis of TR-808 and TR-909 circuits. Key features include master saturation via a WaveShaper with a custom soft-clipping curve, velocity-sensitive envelopes for all drum instruments, and rhythmic humanization through micro-randomized velocities in the Euclidean sequencer. It also fixes a bug where open hi-hat volume was incorrectly mapped to the closed hi-hat gain node.


PR created automatically by Jules for task 4826691370997891434 started by @Pitrat-wav

Implemented advanced DSP-based drum synthesis enhancements based on TR-808/909 research:
- Added master saturation (DRIVE) using a soft-clipping tanh curve in the DrumMachine.
- Implemented velocity sensitivity across all drum models (Kick, Snare, HiHat, Clap).
- Added micro-randomization for velocity in the sequencer loop to simulate analog variance.
- Fixed volume mapping for open hi-hats in the audio store.
- Added a "DRIVE" control knob to the Drums UI.
- Ensured per-hit analog drift (pitch, phase, filter cutoff) is correctly integrated.

Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant