Skip to content

FallingDownDamage Extension#2124

Merged
Coronia merged 17 commits intoPhobos-developers:developfrom
Fly-Star-him:fallingdownfix
Mar 5, 2026
Merged

FallingDownDamage Extension#2124
Coronia merged 17 commits intoPhobos-developers:developfrom
Fly-Star-him:fallingdownfix

Conversation

@Fly-Star-him
Copy link
Contributor

@Fly-Star-him Fly-Star-him commented Mar 1, 2026 •
edited by DeathFishAtEase
Loading

  • Fixed an issue where hover vehicles could not be destroyed after malfunctioning on water surfaces.

  • Fixed an issue where parachute units would die upon landing if bridges were destroyed during their descent.

  • FallingDownDamage.AllowEMP determines whether units incapacitated by EMP can use FallingDownDamage/FallingDownDamage.Water. The default value is true.

运输船修复

  • HoverDrownable allows customization of whether hover vehicles crash and cause death when deactivated.

In rulesmd.ini:

[SOMEVEHICLE]           ; VehicleType
HoverDrownable=true     ; boolean

@github-actions
Copy link

github-actions bot commented Mar 1, 2026 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Fly-Star-him Fly-Star-him changed the title FallingDownDamage Fix FallingDownDamage Extension Mar 1, 2026
@Coronia Coronia added the Tested label Mar 1, 2026
DeathFishAtEase added a commit that referenced this pull request Mar 1, 2026
@DeathFishAtEase
The fix in d87d166 has been replaced by #2124 due to the introduction…
b741d71 
… of a bug

This reverts commit d87d166.
@Coronia Coronia requested review from NetsuNegi and TaranDahl March 2, 2026 02:08
TaranDahl
TaranDahl requested changes Mar 2, 2026
View reviewed changes
Coronia added 2 commits March 4, 2026 10:46
@Coronia
tag name and comment
18189c7
@Coronia
Merge branch 'develop' into fallingdownfix
8fb52d3 
# Conflicts:
#	docs/Whats-New.md
#	docs/locale/zh_CN/LC_MESSAGES/CREDITS.po
@TaranDahl TaranDahl added ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable Bugfix This is a bugfix that does not need documentation beyond mention in changelog ❓Phobos bug Something isn't working properly ❓Vanilla bug Vanilla game bugs that are requested to be fixed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. labels Mar 4, 2026
@DeathFishAtEase
Copy link
Collaborator

DeathFishAtEase commented Mar 4, 2026

Fixed an issue where hover vehicles could not be destroyed after malfunctioning on water surfaces (by FlyStar)

@Fly-Star-him Since when was this Phobos bug introduced? Does it exist in v0.4? Or in DevBuild#48? If it exists in neither, then this log entry would be redundant. If this bug was introduced by d87d166, then it has already been rolled back, and this PR cannot fix a problem that no longer exists—it would also be redundant.

@Fly-Star-him
Copy link
Contributor Author

Fly-Star-him commented Mar 5, 2026

Fixed an issue where hover vehicles could not be destroyed after malfunctioning on water surfaces (by FlyStar)

@Fly-Star-him Since when was this Phobos bug introduced? Does it exist in v0.4? Or in DevBuild#48? If it exists in neither, then this log entry would be redundant. If this bug was introduced by d87d166, then it has already been rolled back, and this PR cannot fix a problem that no longer exists—it would also be redundant.

After the feature was introduced in DevBuild#47, the bug could be triggered. d87d166 merely made it more obvious.

@Coronia Coronia merged commit e24d9a1 into Phobos-developers:develop Mar 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Coronia Coronia Coronia left review comments

@TaranDahl TaranDahl TaranDahl approved these changes

@NetsuNegi NetsuNegi Awaiting requested review from NetsuNegi

Assignees

No one assigned

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog ❓Phobos bug Something isn't working properly ⚙️T1 T1 maintainer review is sufficient Tested ❓Unhardcoding / Customization Make something more tweakable ❓Vanilla bug Vanilla game bugs that are requested to be fixed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fly-Star-him @DeathFishAtEase @Coronia @TaranDahl