features: oriolis ui updates#4
Open
PeterGrace wants to merge 8 commits into
Open
Conversation
- Added topic_name to PointConfig and MonitoredPoint to allow custom MQTT topic names - Implemented wildcard range expansion (e.g., [1..6]) for catalog_ref in sunspec_poll.rs - Updated payload generation to use custom topic names if provided
…d task block Re-enable console_subscriber, opentelemetry::global, and TraceContextPropagator imports in main.rs that were commented out during UI work. Restore console_layer wiring into the tracing subscriber and opentelemetry shutdown in the Ctrl-C handler. In sunspec_unit.rs, remove the long-dead commented-out async populate_models task block (and its now-unused imports) that had been superseded by the synchronous inline call. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Cleans up 16 files modified in this branch:
- Remove unused imports (SqlitePool, TryRecvError, Router, get, post, HashMap, Payload, num_traits::Pow, std::fs, load_config, routing::get)
- Replace len() > 0 with is_empty() checks throughout
- Convert match -> if let for single-pattern matches
- Fix late-init variable declarations to inline initialization
- Remove needless borrows on references already auto-derefed
- Convert try_into().unwrap() to .into() for infallible u32->i64 conversions
- Replace format!("literal") with "literal".to_string()
- Collapse nested if-let chains
- Replace deprecated DateTime::from_utc with from_naive_utc_and_offset
- Convert impl Default manual impls to #[derive(Default)] with #[default]
- Remove dead code (unused query variable, dead grid_import/export_today accumulators)
- Replace println! with info! in refresh_baselines
- Fix let-and-return in make_tracer
- Replace Vec::filter+collect loop with retain()
- Add #[allow(dead_code/clippy::upper_case_acronyms)] where renaming would break other files
- Remove needless mut on non-mutated bindings
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an import of some of the work oriolis was doing offline and asked me to review for possible inclusion in the project.