Skip to content

Add 2 misc blocks a pointer custom type with blocks to go with and add 'index' reporter to for loop#537

Merged
SharkPool-SP merged 13 commits intoPenguinMod:mainfrom
AndrewScripter587:main
Mar 7, 2026
Merged

Add 2 misc blocks a pointer custom type with blocks to go with and add 'index' reporter to for loop#537
SharkPool-SP merged 13 commits intoPenguinMod:mainfrom
AndrewScripter587:main

Conversation

@AndrewScripter587
Copy link
Copy Markdown
Contributor

also the is buffer block uses instanceof now

yay

Copy link
Copy Markdown
Contributor Author

@AndrewScripter587 AndrewScripter587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can someone merge this

@the-can-of-soup
Copy link
Copy Markdown
Contributor

bump

@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

it's been 3 days

Allows casting something like a number to different datatypes without needing to create an array buffer
@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

just added a new block for casting to datatypes without needing like 5 blocks

@AndrewScripter587 AndrewScripter587 changed the title Add a block and add 'index' reporter to for loop Add 2 blocks and add 'index' reporter to for loop Feb 25, 2026
Pointers exist now, and also div Iterators support
@AndrewScripter587 AndrewScripter587 changed the title Add 2 blocks and add 'index' reporter to for loop Add 2 misc blocks, a pointer custom type with blocks to go with, and add 'index' reporter to for loop Feb 25, 2026
@AndrewScripter587 AndrewScripter587 changed the title Add 2 misc blocks, a pointer custom type with blocks to go with, and add 'index' reporter to for loop Add 2 misc blocks a pointer custom type with blocks to go with and add 'index' reporter to for loop Feb 25, 2026
@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

added pointers, and Iterators support as requested by div, hooray

@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

can someone merge this now

@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

please

add null-terminated string support and a copy pointer block
@JeremyGamer13 JeremyGamer13 added the extension update This updates an already existing extension label Feb 27, 2026
@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

Its been 8 days

@the-can-of-soup
Copy link
Copy Markdown
Contributor

R.I.P.

@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

Just realized I had the serializer for the pointer type commented out so projects that used buffer pointers wouldn't save :/

@Steve0Greatness
Copy link
Copy Markdown
Contributor

Its been 8 days

PRs often take awhile to get merged, I find. One PR I've contributed code to has been sitting waiting for a review or merge since November. Just ping the developers in the Discord. It might sound like you'd be annoying them, but otherwise nothing is gonna get done.

@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

Its been 8 days

PRs often take awhile to get merged, I find. One PR I've contributed code to has been sitting waiting for a review or merge since November. Just ping the developers in the Discord. It might sound like you'd be annoying them, but otherwise nothing is gonna get done.

Who should I ping then?

@the-can-of-soup
Copy link
Copy Markdown
Contributor

Its been 8 days

PRs often take awhile to get merged, I find. One PR I've contributed code to has been sitting waiting for a review or merge since November. Just ping the developers in the Discord. It might sound like you'd be annoying them, but otherwise nothing is gonna get done.

Who should I ping then?

find everyone online with the developer role and use pm!wheel dev 1,dev 2, dev 3 etc image

// Notice: the reason I don't use instanceof for checking for my custom type is because it doesn't f**king work for some reason

(async function(Scratch) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uneeded spaces

emptyInputPath: "m 31 0 h 10 h 10 a 4 4 0 0 1 4 4 h 7 l -7 7 v 10 l 7 7 h -7 a 4 4 0 0 1 -4 4 h -10 h -10 h -10 h -10 a 4 4 0 0 1 -4 -4 h -7 l 7 -7 v -10 l -7 -7 h 7 a 4 4 0 0 1 4 -4 z",
emptyInputWidth: 16 * ScratchBlocks.BlockSvg.GRID_UNIT,
leftPath: (block) => {
console.log(block)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this log

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah

TYPE = Cast.toString(TYPE)
return new ArrayBufferPointerType(PTR.buffer,PTR.index,TYPE,ENDIAN)
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove thiss space

}

isPointer({VALUE}) {
return (!!VALUE && VALUE instanceof ArrayBufferPointerType)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!VALUE does nothing here

}

copyPointer({PTR}) {
if (!PTR || !(PTR instanceof ArrayBufferPointerType)) return;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a reporter, it should always return something

arr.forEach((value, index) => {
BUFFER.dataView.setUint8(index + INDEX, value)
})

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space

Comment on lines +1229 to +1230
if (BUFFER == undefined && !agBuffer.disableErrorHandling) return;
if (STRING == undefined && !agBuffer.disableErrorHandling) return;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be simplified

Apply requested changes from @SharkPool-SP
@AndrewScripter587
Copy link
Copy Markdown
Contributor Author

Requested changes applied

@SharkPool-SP SharkPool-SP merged commit 8127584 into PenguinMod:main Mar 7, 2026
1 check failed
@the-can-of-soup
Copy link
Copy Markdown
Contributor

thank goodness
my inbox was exploding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension update This updates an already existing extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants