Skip to content

fix: add mkdir to Makefile#17

Merged
M03ED merged 2 commits into
PasarGuard:devfrom
wavy-cat:main
Nov 5, 2025
Merged

fix: add mkdir to Makefile#17
M03ED merged 2 commits into
PasarGuard:devfrom
wavy-cat:main

Conversation

@wavy-cat
Copy link
Copy Markdown
Contributor

@wavy-cat wavy-cat commented Nov 3, 2025

This PR adds the creation of the certs directory for generate_server_cert and generate_client_cert to the Makefile.

Summary by CodeRabbit

  • Bug Fixes

    • Ensured certificate directory is created before certificate generation to prevent setup failures.
  • Chore

    • No functional changes to how the application is started; formatting-only updates.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 3, 2025

Walkthrough

Makefile updated to create a ./certs directory before generating server and client certificates; the serve target's go run invocation was reformatted only (no behavioral change).

Changes

Cohort / File(s) Summary
Build configuration
Makefile
Added mkdir -p ./certs before generate_server_cert and generate_client_cert; reformatted go run main.go serve in the serve target (cosmetic, no functional change).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I dug a little folder, snug and neat,
Certificates now have a proper seat.
A tidy line, a tiny tweak,
The Makefile hums — no need to peek! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding mkdir commands to the Makefile to ensure the certs directory exists before certificate generation.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 830d3d9 and 16097c7.

📒 Files selected for processing (1)
  • Makefile (2 hunks)
🔇 Additional comments (2)
Makefile (2)

45-45: Excellent! The critical idempotent mkdir -p fix is properly applied.

Both certificate generation targets now use mkdir -p ./certs, which prevents failures on subsequent invocations or when targets are executed in sequence. This resolves the critical issue flagged in the prior review.

Also applies to: 52-52


117-117: Formatting change in serve target looks good.

The go run main.go serve invocation is correctly preserved with no behavioral changes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b243ae2 and 830d3d9.

📒 Files selected for processing (1)
  • Makefile (2 hunks)
🔇 Additional comments (1)
Makefile (1)

116-117: Verify the serve target behavior change.

The AI summary indicates the error-ignore prefix was removed from the go run command, which changes the serve target from silently ignoring errors to propagating them. Confirm this intentional change doesn't break existing CI/CD workflows, local development patterns, or error handling that relied on the previous behavior.

Comment thread Makefile Outdated
@M03ED
Copy link
Copy Markdown
Contributor

M03ED commented Nov 4, 2025

change branch to dev

@wavy-cat wavy-cat changed the base branch from main to dev November 4, 2025 14:58
@M03ED M03ED merged commit 44c31d1 into PasarGuard:dev Nov 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants