Conversation
hknahal
requested changes
Mar 3, 2026
- strict file typing on size - export according to original input type
hknahal
approved these changes
Mar 6, 2026
Contributor
hknahal
left a comment
hknahal
left a comment
There was a problem hiding this comment.
LGTM! Parsing error resolved and "help" text updated
lindaxiang
reviewed
Mar 6, 2026
| @@ -0,0 +1,3 @@ | |||
| study_id submitter_participant_id age_at_enrollment vital_status cause_of_death age_at_death | |||
| EXAMPLE-CA DONOR_5 Deceased Died of cancer 21.0 | |||
| EXAMPLE-CA DONOR_6 | |||
Contributor
There was a problem hiding this comment.
Are these files purposely submitted here?
lindaxiang
requested changes
Mar 6, 2026
lindaxiang
reviewed
Mar 6, 2026
| parser.add_argument('-i', '--input', dest="input", help="The custom schema that makes references to extension and base schemas", required=True,type=str) | ||
| parser.add_argument('-s', '--size', dest="size", help="Number of records the file should be divided into", default=True,type=int) | ||
| parser.add_argument('-o', '--output_directory', dest="out_dir", help="The main directory containing folders : Base, Extension, Custom", default=True,type=str) | ||
|
|
Contributor
There was a problem hiding this comment.
The descriptions for parameters in help still seem to be confusion.
-- input: "The custom schema that makes references to extension and base schemas", is it correct?
-- size: "default=True", should it be a integer?
--output_directory: "The main directory containing folders : Base, Extension, Custom", is it correct?
"default=True", should it be a string?
lindaxiang
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.