Skip to content

fix(plan): dont add junction on plan patch #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplacht merged 1 commit into from
Apr 21, 2026
Merged

fix(plan): dont add junction on plan patch #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions backend/planning/api/serializers/plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,17 @@ def create(self, validated_data):

@transaction.atomic
def update(self, instance, validated_data):
user = self.context['request'].user
empire_uuid = validated_data.pop('empire_uuid', None)
_user = self.context['request'].user
_empire_uuid = validated_data.pop('empire_uuid', None)

# update plan fields
instance = super().update(instance, validated_data)

# no junction update on update, only on create

# handle junction
if empire_uuid:
self._link_empire(user, instance, empire_uuid)
# if empire_uuid:
# self._link_empire(user, instance, empire_uuid)

return instance

Expand Down
Loading