Potential fix for code scanning alert no. 9: Uncontrolled data used in path expression#7
Merged
Merged
Conversation
…n path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| real_log_path = os.path.realpath(user_path) | ||
| try: | ||
| real_log_path = Path(user_path).resolve(strict=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/PRATHAM777P/IPWatchdog/security/code-scanning/9
Use a stricter, explicit path-allowlist validation with
pathlib.Path.resolve()and enforce containment against configured roots using relative-path checks. Then reduce race risk by opening exactly the validated resolved path and removing redundant pre-checks.Best fix in this snippet:
app.py, update_validated_monitor_log_path:Path(user_path).resolve(strict=True)(must exist).Path(...).resolve(strict=True)and ensure it is a directory.resolved_user.relative_to(resolved_root)succeeds.monitor_start, replaceos.path.isfile(...)check with error handling around validation/open lifecycle:400/403.404.tail_worker, keep using the validated resolved path.This preserves behavior (monitoring allowed local log files) while making sanitization clearer and stronger for both security and static analysis.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.