Potential fix for code scanning alert no. 8: Uncontrolled data used in path expression#5
Merged
Merged
Conversation
…n path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return jsonify({"error": "Path not in allowed monitor paths"}), 403 | ||
|
|
||
| if not os.path.isfile(log_path): | ||
| if not os.path.isfile(real_log_path): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/PRATHAM777P/IPWatchdog/security/code-scanning/8
To fix this safely without changing intended behavior, canonicalize both the user-provided path and allowed roots with
os.path.realpath, then enforce containment usingos.path.commonpath(notstartswith). This prevents traversal and prefix-bypass issues. Also ensure the provided path is absolute before validation to avoid ambiguous relative resolution.In
app.py, insidemonitor_start()(around lines 258–267), replace the current allowlist check:real_log_path = os.path.realpath(log_path).MONITOR_ALLOWED_PATHS.os.path.commonpath([real_log_path, allowed_root]) == allowed_rootfor at least one allowed root.real_log_pathforos.path.isfile(...),open(...), and response payload to keep path use consistent and validated.No new imports are needed (
osis already imported).Suggested fixes powered by Copilot Autofix. Review carefully before merging.