[enhancement] HMS+HMS Mergers rejuvenation according to Schneider+2016#788
Open
[enhancement] HMS+HMS Mergers rejuvenation according to Schneider+2016#788
Conversation
…ey only come from the core of the postMS star
…s (with changes) and the star_base (the HMS, star 1 probably) becomes massless remnant
…d the possibility to match with total_mass_h1
for more information, see https://pre-commit.ci
…to 'Glebbeek+2013'
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
With @dimsour94 we tested it with various options run. |
added the options and default values of of rel_mass_lost_HMS_HMS and HMS_HMS_merging_rejuvenation in the .ini file of the population.
maxbriel
changed the title
sgossage
reviewed
Mar 24, 2026
| # if given, use an absolute filepath to user defined step: | ||
| # ['<PATH_TO_PY_FILE>', '<NAME>'] | ||
| rel_mass_lost_HMS_HMS = "Glebbeek+2013" | ||
| # [0-1) or "Glebbeek+2013" (dependent on mass ratio q) |
Contributor
There was a problem hiding this comment.
Suggested change
| # [0-1) or "Glebbeek+2013" (dependent on mass ratio q) | |
| # float in range [0-1) or "Glebbeek+2013" (q-dependent, according to Eq. 4 of Glebbeek et al. 2013, MNRAS, 434, 3497) |
Contributor
|
We should merge PR#785 into |
Contributor
|
We should update the docs here with these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HMS_HMS_merging_rejuvenation = Trueto stronger rejuvenation of MS+MS mergers (according to Glebbeek+2023, Schneider+2016, following the recent Wang+2025 too). So it should be considered a change in POSYDON results for few types mergers-This PR includes already the changes in #785 and builds on it. If accepted, that PR becomes unnecessary