Skip to content

[enhancement] Maltsev prescription#786

Draft
ezapartas wants to merge 20 commits intov2.3from
Maltsev_prescription
Draft

[enhancement] Maltsev prescription#786
ezapartas wants to merge 20 commits intov2.3from
Maltsev_prescription

Conversation

@ezapartas
Copy link
Copy Markdown
Contributor

Implementing Maltsev explodablity criterion:

As an alternative to Patton20+Ertl16 criterion, now we have Patton20+Maltsev25 criterion

For now, implementation only for M_CO <= 10 Msun (as in Patton20+Ertl16 criterion). Still needed to implement the case for M_CO > 10 Msun (where the MT history is needed right now).

To work it still needs:

  • to include the Kepler_sc.dat table as in the POSYDON data of Patton, so that it is able to be read.
  • to make new SN MODELS based on this prescription for initial-final interpolation

Comment thread posydon/binary_evol/SN/step_SN.py Outdated
Comment thread posydon/binary_evol/SN/step_SN.py Outdated
Comment thread posydon/binary_evol/SN/step_SN.py
@astroJeff astroJeff marked this pull request as draft February 5, 2026 15:40
@astroJeff astroJeff marked this pull request as draft February 5, 2026 15:40
@maxbriel maxbriel changed the base branch from main to v2.3 February 10, 2026 08:21
@maxbriel maxbriel added the enhancement New feature or request label Feb 10, 2026
@maxbriel maxbriel changed the title Maltsev prescription [enhancement] Maltsev prescription Feb 10, 2026
Copy link
Copy Markdown
Contributor

@dimsour94 dimsour94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a population of 5,000 systems using this branch, including the Maltsev central entropy file with nearest-neighbour and interp_values set to False, and it worked well. The only remaining open issue is the treatment of SNe forming fallback BHs: we currently assume a fallback fraction of 0.99, but we still need to determine what the appropriate fallback fraction should be.

@maxbriel maxbriel added this to the v2.3 milestone Feb 13, 2026
Comment thread posydon/binary_evol/SN/step_SN.py Outdated
@sgossage
Copy link
Copy Markdown
Contributor

sgossage commented Apr 7, 2026

@ezapartas @dimsour94 is this ready for review?

In principle, things look good outside of the TODO points raised in the PR's description. The current v2.3 branch also needs to be merged in to this.

@sgossage sgossage self-requested a review April 7, 2026 20:24
@maxbriel
Copy link
Copy Markdown
Collaborator

I've updated this PR with the unaddressed comments:

  • Merger v2.3 into this branch
  • I fixed the setting of f_fb and state in the case conserve_hydrogen==True.
  • I made sure the k1 and k2 parameters in explod_crit are passed into it from the main function, instead of redefining them. Additionally, there was a typo in the k2 parameter (0.421 instead of 0.420).
  • Changed to self.RNG instead of random.
  • Some additional cleanup of comments and indentations.

One problem I am seeing with this PR is the backwards compatibility. It forces the user to always have the new Kepler_sc_table.dat file in their PATH_TO_POSYDON_DATA, even if they are not using the Matlsev prescription.
Do we want this?

Next steps:

  1. Add Kepler_sc_table.dat to POSYDON_auxilliary_data.
  2. Post-process grids for new SN_models to be included and retrain the interpolators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants