Conversation
…glestar object as scalar
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dimsour94
left a comment
There was a problem hiding this comment.
I ran a population of 5,000 systems using this branch, including the Maltsev central entropy file with nearest-neighbour and interp_values set to False, and it worked well. The only remaining open issue is the treatment of SNe forming fallback BHs: we currently assume a fallback fraction of 0.99, but we still need to determine what the appropriate fallback fraction should be.
|
@ezapartas @dimsour94 is this ready for review? In principle, things look good outside of the TODO points raised in the PR's description. The current |
|
I've updated this PR with the unaddressed comments:
One problem I am seeing with this PR is the backwards compatibility. It forces the user to always have the new Next steps:
|
Implementing Maltsev explodablity criterion:
As an alternative to Patton20+Ertl16 criterion, now we have Patton20+Maltsev25 criterion
For now, implementation only for M_CO <= 10 Msun (as in Patton20+Ertl16 criterion). Still needed to implement the case for M_CO > 10 Msun (where the MT history is needed right now).
To work it still needs: