Improve ease of extention#89
Open
andrewnicols wants to merge 1 commit into
Open
Conversation
In our usage we need to extend the ControllerInvoker to have responses normalised from a generic Payload into a standard Response. To make this easier it would be helpful if some private methods were instead protected and the Invoker fetching the default resolver chain were separated out from the creation of the ControllerInvoker. Fixes #105
5d72a56 to
dedf7f5
Compare
Member
|
Thanks for both PRs! My goal with this bridge is to provide an opinionated default for Slim so that users can get started immediately. The bridge itself is extremely simple. If you have advanced needs, I think it makes much more sense to copy the classes and edit them, they're super easy to understand. However if we want to change the defaults I'm all ears, but #86 (comment) tells me that the bridge is currently aligned with how Slim works, so I'm not sure we want to change them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our usage we need to extend the ControllerInvoker to have responses normalised from a generic Payload into a standard Response.
To make this easier it would be helpful if some private methods were instead protected and the Invoker fetching the default resolver chain were separated out from the creation of the ControllerInvoker.
Fixes #105
You can see our proposed implementation of the ControllerInvoker here. With the proposed patch here, that would be vastly simplified and easier to maintain, something like:
#[\Override] protected function processResponse($response) { return \core\di::get(response_handler::class)->standardise_response($response); }Likewise our custom Bridge implementation would be vastly simplified by breaking apart the
Bridge::createControllerInvokermethod from this, to: